WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED DUPLICATE of
bug 41341
79858
The way we invalidate high accuracy geolocation listener is incorrect
https://bugs.webkit.org/show_bug.cgi?id=79858
Summary
The way we invalidate high accuracy geolocation listener is incorrect
Benjamin Poulain
Reported
2012-02-28 19:11:05 PST
Add a high accuracy Add a non-high accuracy Remove the high accuracy -->we stay in high accuracy The problem is we have one client for all the controller, and the controller assume its client manage setEnableHighAccuracy per controller: void GeolocationController::removeObserver(Geolocation* observer) { if (!m_observers.contains(observer)) return; m_observers.remove(observer); m_highAccuracyObservers.remove(observer); if (m_client) { if (m_observers.isEmpty()) m_client->stopUpdating(); else if (m_highAccuracyObservers.isEmpty()) m_client->setEnableHighAccuracy(false); } }
Attachments
Add attachment
proposed patch, testcase, etc.
Benjamin Poulain
Comment 1
2012-02-29 11:50:36 PST
<
rdar://problem/10951749
>
Steve Block
Comment 2
2012-05-21 10:13:59 PDT
> The problem is we have one client for all the controller, and the controller > assume its client manage setEnableHighAccuracy per controller:
Do you mean that you're sharing a single implementation of GeolocationClient between all GeolocationController instances? That would be a port-specific bug. Is this on Mac?
Steve Block
Comment 3
2012-05-21 10:24:03 PDT
Having re-read this bug, I think you're referring to the problem in
Bug 41341
?
Benjamin Poulain
Comment 4
2012-05-21 12:08:47 PDT
Yep. I close this bug as duplicate. *** This bug has been marked as a duplicate of
bug 41341
***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug