RESOLVED FIXED 79486
[Qt] API: Unify the loading properties and signals. 
https://bugs.webkit.org/show_bug.cgi?id=79486
Summary [Qt] API: Unify the loading properties and signals.
Jocelyn Turcotte
Reported 2012-02-24 06:35:44 PST
[Qt] API: Unify the loading properties and signals.
Attachments
Patch (73.22 KB, patch)
2012-02-24 06:44 PST, Jocelyn Turcotte 		hausmann: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jocelyn Turcotte
Comment 1 2012-02-24 06:44:35 PST
Created attachment 128725 [details] Patch
Simon Hausmann
Comment 2 2012-02-24 08:03:01 PST
Comment on attachment 128725 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128725&action=review r=me. The only iffy thing that I think can be easily fixed if it actually turns out to be a problem (I'm not sure it is), is that the argument to the loadingChanged signal is very short-lived. This isn't quite specific to this patch, but perhaps we should consider using actual JavaScript objects as parameters (QJSValue) with according properties. (or JSON if you want so :) > Source/WebKit2/UIProcess/API/qt/qwebloadrequest_p.h:47 > + QWebLoadRequestPrivate* d; As a general rule perhaps we should consider adopting the Qt rule of using QScopedPointer for the d-pointer.
Jocelyn Turcotte
Comment 3 2012-02-24 09:51:13 PST
Committed r108815: <http://trac.webkit.org/changeset/108815>
Note You need to log in before you can comment on or make changes to this bug.