RESOLVED FIXED 78788
[Qt] Move event conversion functions from WebCore to WebKit 
https://bugs.webkit.org/show_bug.cgi?id=78788
Summary [Qt] Move event conversion functions from WebCore to WebKit
Simon Hausmann
Reported 2012-02-16 01:56:21 PST
[Qt] Move event conversion functions from WebCore to WebKit
Attachments
[Qt] Move event conversion functions from WebCore to WebKit (22.82 KB, patch)
2012-02-16 02:00 PST, Simon Hausmann 		no flags
DetailsFormatted DiffDiff
[Qt] Move event conversion functions from WebCore to WebKit (22.71 KB, patch)
2012-02-16 02:20 PST, Simon Hausmann 		kenneth: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Hausmann
Comment 1 2012-02-16 02:00:38 PST
Created attachment 127330 [details] [Qt] Move event conversion functions from WebCore to WebKit
Kenneth Rohde Christiansen
Comment 2 2012-02-16 02:12:37 PST
Comment on attachment 127330 [details] [Qt] Move event conversion functions from WebCore to WebKit View in context: https://bugs.webkit.org/attachment.cgi?id=127330&action=review > Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:131 > +WebKitPlatformMouseEvent::WebKitPlatformMouseEvent(QInputEvent* event, int clickCount) WebPlatformMouseEvent? :-) > Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:163 > +PlatformMouseEvent convertMouseEvent(QInputEvent* event, int clickCount) > +{ > + return WebKitPlatformMouseEvent(event, clickCount); > +} What do you gain with these methods? I am not sure they make the code clearer
Simon Hausmann
Comment 3 2012-02-16 02:15:38 PST
Comment on attachment 127330 [details] [Qt] Move event conversion functions from WebCore to WebKit View in context: https://bugs.webkit.org/attachment.cgi?id=127330&action=review >> Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:131 >> +WebKitPlatformMouseEvent::WebKitPlatformMouseEvent(QInputEvent* event, int clickCount) > > WebPlatformMouseEvent? :-) In WebKit2 the same "class" is called WebKit2PlatformMouseEvent, so I thought I'd be consistent. >> Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:163 >> +} > > What do you gain with these methods? I am not sure they make the code clearer I can also make these classes public if you prefer that, I choose that method because it's also used in WK2's WebEventConversion.
Simon Hausmann
Comment 4 2012-02-16 02:17:34 PST
Comment on attachment 127330 [details] [Qt] Move event conversion functions from WebCore to WebKit View in context: https://bugs.webkit.org/attachment.cgi?id=127330&action=review > Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:206 > + // ### PlatformEvent(PlatformEvent::Wheel, e->modifiers() & Qt::ShiftModifier, e->modifiers() & Qt::ControlModifier, e->modifiers() & Qt::AltModifier, e->modifiers() & Qt::MetaModifier, WTF::currentTime()) Ooops, I meant to fix this. Will upload a new patch.
Simon Hausmann
Comment 5 2012-02-16 02:20:54 PST
Created attachment 127332 [details] [Qt] Move event conversion functions from WebCore to WebKit
Kenneth Rohde Christiansen
Comment 6 2012-02-16 02:25:20 PST
Comment on attachment 127332 [details] [Qt] Move event conversion functions from WebCore to WebKit View in context: https://bugs.webkit.org/attachment.cgi?id=127332&action=review rs=me > Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:136 > +#ifndef QT_NO_CONTEXTMENU didnt we want to get rid of these?
Simon Hausmann
Comment 7 2012-02-16 02:31:30 PST
Committed r107915: <http://trac.webkit.org/changeset/107915>
Note You need to log in before you can comment on or make changes to this bug.