RESOLVED FIXED 78524
webkitpy should support Android 
https://bugs.webkit.org/show_bug.cgi?id=78524
Summary webkitpy should support Android
Adam Barth
Reported 2012-02-13 13:41:20 PST
webkitpy should support Android
Attachments
snapshot (40.86 KB, patch)
2012-02-13 13:41 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-02-13 13:41:43 PST
Created attachment 126822 [details] snapshot
Eric Seidel (no email)
Comment 2 2012-02-13 13:47:23 PST
Comment on attachment 126822 [details] snapshot View in context: https://bugs.webkit.org/attachment.cgi?id=126822&action=review I would have probably broken this file out into smaller pieces, but I think that's also something we can do later after the android port is working. > Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:493 > +class ChromiumAndroidDriver(chromium.ChromiumDriver): > + """Abstract interface for test_shell.""" Really? We have yet another driver...? > Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py:78 > + _set_gpu_options(self) Odd function. > Tools/Scripts/webkitpy/layout_tests/port/factory.py:76 > + else: > + return 'chromium-linux' No else after return.
Eric Seidel (no email)
Comment 3 2012-02-13 13:47:58 PST
Comment on attachment 126822 [details] snapshot View in context: https://bugs.webkit.org/attachment.cgi?id=126822&action=review > Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:50 > +_log = logging.getLogger('webkitpy.layout_tests.port.chromium_android') I think we normally use getLogger(__file__)
Adam Barth
Comment 4 2012-02-14 17:04:25 PST
This is done. I don't have a target device, so it's hard for me to test that everything is working. I suspect there are some bugs, but we can handle them separately as we find them.
Note You need to log in before you can comment on or make changes to this bug.