WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
78490
Rename [JSGenerateToJS] to [JSGenerateToJSObject]
https://bugs.webkit.org/show_bug.cgi?id=78490
Summary
Rename [JSGenerateToJS] to [JSGenerateToJSObject]
Kentaro Hara
Reported
2012-02-13 06:05:18 PST
We can rename [JSGenerateToJS] to [JSGenerateToJSObject], for naming consistency with [CustomToJSObject], [JSCustomToJSObject] and [V8CustomToJSObject].
Attachments
Patch
(20.94 KB, patch)
2012-02-13 06:07 PST
,
Kentaro Hara
no flags
Details
Formatted Diff
Diff
rebased patch for commit
(20.94 KB, patch)
2012-02-14 16:48 PST
,
Kentaro Hara
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kentaro Hara
Comment 1
2012-02-13 06:07:10 PST
Created
attachment 126764
[details]
Patch
WebKit Review Bot
Comment 2
2012-02-13 16:44:34 PST
Comment on
attachment 126764
[details]
Patch Rejecting
attachment 126764
[details]
from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: e/webaudio/MediaElementAudioSourceNode.idl patching file Source/WebCore/webaudio/OfflineAudioCompletionEvent.idl patching file Source/WebCore/webaudio/RealtimeAnalyserNode.idl patching file Source/WebCore/webaudio/WaveShaperNode.idl patching file Source/WebCore/workers/SharedWorker.idl patching file Source/WebCore/workers/Worker.idl Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output:
http://queues.webkit.org/results/11518021
Kentaro Hara
Comment 3
2012-02-14 16:48:52 PST
Created
attachment 127080
[details]
rebased patch for commit
WebKit Review Bot
Comment 4
2012-02-14 18:05:38 PST
Comment on
attachment 127080
[details]
rebased patch for commit Clearing flags on attachment: 127080 Committed
r107768
: <
http://trac.webkit.org/changeset/107768
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug