RESOLVED FIXED 77706
Remove [LegacyParent] from CodeGeneratorGObject.pm, and rename it to [JSLegacyParent] 
https://bugs.webkit.org/show_bug.cgi?id=77706
Summary Remove [LegacyParent] from CodeGeneratorGObject.pm, and rename it to [JSLegac...
Kentaro Hara
Reported 2012-02-02 19:43:18 PST
[LegacyParent] is a JSC-specific IDL attribute, and we can rename it to [JSLegacyParent]. Also, we need to remove dead code about [LegacyParent] from CodeGeneratorGObject.pm.
Attachments
Patch (4.61 KB, patch)
2012-02-02 19:45 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-02-02 19:45:38 PST
Created attachment 125244 [details] Patch
Adam Barth
Comment 2 2012-02-03 00:47:20 PST
Comment on attachment 125244 [details] Patch I think this rename names sense given that it's a legacy attribute.
Kentaro Hara
Comment 3 2012-02-03 00:51:21 PST
(In reply to comment #2) > (From update of attachment 125244 [details]) > I think this rename names sense given that it's a legacy attribute. Do you mean we should rename it better?
Adam Barth
Comment 4 2012-02-03 00:59:38 PST
> > I think this rename names sense given that it's a legacy attribute. > > Do you mean we should rename it better? I fail at typing. I meant to say "I think this rename does make sense given that it's a legacy attribute." :)
WebKit Review Bot
Comment 5 2012-02-03 01:55:10 PST
Comment on attachment 125244 [details] Patch Clearing flags on attachment: 125244 Committed r106639: <http://trac.webkit.org/changeset/106639>
WebKit Review Bot
Comment 6 2012-02-03 01:55:15 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.