RESOLVED FIXED 76241
Move ShadowContentElement from dom/ to html/ and make ShadowContentElement subclass of HTMLElement
https://bugs.webkit.org/show_bug.cgi?id=76241
Summary Move ShadowContentElement from dom/ to html/ and make ShadowContentElement su...
Shinya Kawanaka
Reported 2012-01-12 19:44:47 PST
Moves ShadowContentElement from dom/ to html/ We should take into account to dom shouldn't depend on html.
Attachments
Build Test (84.52 KB, patch)
2012-01-16 22:21 PST, Shinya Kawanaka
no flags
Build Test Again (104.87 KB, patch)
2012-01-16 22:51 PST, Shinya Kawanaka
no flags
Build Test Again (102.84 KB, patch)
2012-01-16 23:24 PST, Shinya Kawanaka
no flags
Build Test (103.21 KB, patch)
2012-01-16 23:50 PST, Shinya Kawanaka
no flags
Build Test (115.31 KB, patch)
2012-01-17 00:33 PST, Shinya Kawanaka
no flags
Build Test (115.17 KB, patch)
2012-01-17 00:45 PST, Shinya Kawanaka
no flags
Patch (115.72 KB, patch)
2012-01-17 01:37 PST, Shinya Kawanaka
no flags
Patch for landing (107.12 KB, patch)
2012-01-17 23:38 PST, Shinya Kawanaka
no flags
Hajime Morrita
Comment 1 2012-01-12 20:11:22 PST
Note that ShadowContentElement should become HTMLContentElement, which should be a subclass of HTMLElement.
Shinya Kawanaka
Comment 2 2012-01-16 22:21:40 PST
Created attachment 122715 [details] Build Test
Gyuyoung Kim
Comment 3 2012-01-16 22:26:03 PST
Comment on attachment 122715 [details] Build Test Attachment 122715 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/11267065
Early Warning System Bot
Comment 4 2012-01-16 22:35:42 PST
Shinya Kawanaka
Comment 5 2012-01-16 22:51:35 PST
Created attachment 122716 [details] Build Test Again
Shinya Kawanaka
Comment 6 2012-01-16 23:24:32 PST
Created attachment 122717 [details] Build Test Again
Shinya Kawanaka
Comment 7 2012-01-16 23:50:53 PST
Created attachment 122720 [details] Build Test
Collabora GTK+ EWS bot
Comment 8 2012-01-17 00:04:41 PST
Comment on attachment 122720 [details] Build Test Attachment 122720 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11262092
Shinya Kawanaka
Comment 9 2012-01-17 00:33:26 PST
Created attachment 122726 [details] Build Test
Gyuyoung Kim
Comment 10 2012-01-17 00:42:41 PST
Comment on attachment 122726 [details] Build Test Attachment 122726 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/11269121
Shinya Kawanaka
Comment 11 2012-01-17 00:45:12 PST
Created attachment 122729 [details] Build Test
Shinya Kawanaka
Comment 12 2012-01-17 01:37:06 PST
Dimitri Glazkov (Google)
Comment 13 2012-01-17 09:29:18 PST
Comment on attachment 122735 [details] Patch make sure Safari/Mac builds before landing.
Shinya Kawanaka
Comment 14 2012-01-17 23:38:38 PST
Created attachment 122879 [details] Patch for landing
Shinya Kawanaka
Comment 15 2012-01-17 23:39:54 PST
(In reply to comment #13) > (From update of attachment 122735 [details]) > make sure Safari/Mac builds before landing. Thank you for reviewing. I've confirmed it builds on Snow Leopard Mac in my environment.
WebKit Review Bot
Comment 16 2012-01-18 01:15:41 PST
Comment on attachment 122879 [details] Patch for landing Clearing flags on attachment: 122879 Committed r105249: <http://trac.webkit.org/changeset/105249>
WebKit Review Bot
Comment 17 2012-01-18 01:15:48 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.