Created attachment 120710 [details] ROLLOUT of r103785 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.

Attachment 120710 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1 Source/WebKit/chromium/src/WebWorkerImpl.cpp:48: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/chromium/src/WebWorkerImpl.cpp:52: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/chromium/src/WebWorkerImpl.cpp:128: platform_channel is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebKit/chromium/src/WebSharedWorkerImpl.cpp:45: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/chromium/src/WebWorkerBase.h:128: The parameter name "context" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit/chromium/src/WebWorkerBase.h:133: The parameter name "context" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit/chromium/src/WebWorkerBase.h:139: The parameter name "context" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit/chromium/src/WebWorkerBase.h:150: The parameter name "context" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit/chromium/src/WebWorkerBase.h:154: The parameter name "context" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit/chromium/src/WebWorkerBase.h:158: The parameter name "context" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit/chromium/src/WebWorkerBase.h:161: The parameter name "context" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit/chromium/src/WebSharedWorkerImpl.h:50: The parameter name "client" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit/chromium/src/WebWorkerImpl.h:45: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebKit/chromium/src/WebWorkerImpl.h:46: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebKit/chromium/src/WebWorkerImpl.h:51: The parameter name "client" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit/chromium/src/WebWorkerImpl.h:72: The parameter name "context" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit/chromium/public/WebCommonWorkerClient.h:86: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebKit/chromium/public/WebCommonWorkerClient.h:93: The parameter name "client" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 18 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.

Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.

Comment on attachment 120710 [details] ROLLOUT of r103785 Clearing flags on attachment: 120710 Committed r103787: <http://trac.webkit.org/changeset/103787>

All reviewed patches have been landed. Closing bug.