RESOLVED FIXED 75110
[Chromium] fast/filesystem/op-restricted-chars.html fails on Windows 
https://bugs.webkit.org/show_bug.cgi?id=75110
Summary [Chromium] fast/filesystem/op-restricted-chars.html fails on Windows
Ryosuke Niwa
Reported 2011-12-22 12:13:54 PST
fast/filesystem/op-restricted-chars.html is failing on Windows because you can't have : in filenames on Windows: * Running: RestrictedChars PASS Succeeded: "/".getFile("a<b") PASS Succeeded: "/".getFile("a>b") FAIL Got unexpected error 1 while "/".getFile("a:b") FAIL Got error 1 PASS successfullyParsed is true TEST COMPLETE http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=fast%2Ffilesystem%2Fop-restricted-chars.html
Attachments
Patch (1.45 KB, patch)
2012-03-07 13:29 PST, Eric U. 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric U.
Comment 1 2011-12-22 15:22:06 PST
Arg. This doesn't hit the disk with that name; it must be having a problem with the file_util library.
Eric U.
Comment 2 2012-01-04 10:30:44 PST
(In reply to comment #1) > Arg. This doesn't hit the disk with that name; it must be having a problem with the file_util library. Actually, Windows doesn't allow < or > either, but those are passing. I'll dig in as soon as I can get my Windows dev setup up to date.
Eric U.
Comment 3 2012-02-08 16:23:42 PST
I tracked it down. It's because the file name starts with "a:", so when we call BaseName on it [in Chromium code, not WebKit], it thinks that's a drive name and pulls it off. So the test would have passed if it were "aa:b", but "a:b" fails. Most likely I'll need to add an option to BaseName to ignore drive letters when used on paths that aren't really system paths.
Eric U.
Comment 4 2012-03-07 13:29:52 PST
Created attachment 130682 [details] Patch
Eric U.
Comment 6 2012-03-12 10:42:54 PDT
Committed r110444: <http://trac.webkit.org/changeset/110444>
Note You need to log in before you can comment on or make changes to this bug.