RESOLVED FIXED 74405
[Qt][WK2] Remove statusBarMessageChanged 
https://bugs.webkit.org/show_bug.cgi?id=74405
Summary [Qt][WK2] Remove statusBarMessageChanged
Jesus Sanchez-Palencia
Reported 2011-12-13 06:12:08 PST
It's common sense that we should rename this API (to statusMessageChanged?!). Maybe there should also be a statusMessage property, but this needs to be discussed.
Attachments
Patch (7.41 KB, patch)
2011-12-13 14:41 PST, Rafael Brandao 		no flags
DetailsFormatted DiffDiff
Patch (5.13 KB, patch)
2011-12-20 06:24 PST, Simon Hausmann 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Rafael Brandao
Comment 1 2011-12-13 14:41:16 PST
Created attachment 119086 [details] Patch
Caio Marcelo de Oliveira Filho
Comment 2 2011-12-15 06:46:23 PST
LGTM.
Simon Hausmann
Comment 3 2011-12-16 12:29:21 PST
I'm not too fond of having the property there without any proof that this would actually be useful. We're not even using it ourselves in the mini browser, so how can we be sure it's useful? Even with the signal I have to wonder: Do other browsers actually use this right now? (It's not used for link hovering) (I know it's in the WK2 C API, but does anyone know of an example web app/site that uses window.status that works?)
Caio Marcelo de Oliveira Filho
Comment 4 2011-12-16 12:44:34 PST
(In reply to comment #3) > I'm not too fond of having the property there without any proof that this would actually be useful. We're not even using it ourselves in the mini browser, so how can we be sure it's useful? > > Even with the signal I have to wonder: Do other browsers actually use this right now? (It's not used for link hovering) > > (I know it's in the WK2 C API, but does anyone know of an example web app/site that uses window.status that works?) Interesting point. It seems that "window.status" itself is not expected to work in HTML5 (even though WebKit supports it). http://dev.w3.org/html5/spec/Overview.html#dom-window-status
Rafael Brandao
Comment 5 2011-12-16 16:34:34 PST
(In reply to comment #4) > (In reply to comment #3) > > I'm not too fond of having the property there without any proof that this would actually be useful. We're not even using it ourselves in the mini browser, so how can we be sure it's useful? > > > > Even with the signal I have to wonder: Do other browsers actually use this right now? (It's not used for link hovering) > > > > (I know it's in the WK2 C API, but does anyone know of an example web app/site that uses window.status that works?) > > Interesting point. It seems that "window.status" itself is not expected to work in HTML5 (even though WebKit supports it). > > http://dev.w3.org/html5/spec/Overview.html#dom-window-status To be honest, I discovered this feature when I've worked on this bug. Never heard about it before and I'm afraid this can't be very useful as well. If we want to at least support this feature, then maybe we should just have the signal as we had before? The test case could be modified a bit.
Simon Hausmann
Comment 6 2011-12-19 06:05:28 PST
(In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > I'm not too fond of having the property there without any proof that this would actually be useful. We're not even using it ourselves in the mini browser, so how can we be sure it's useful? > > > > > > Even with the signal I have to wonder: Do other browsers actually use this right now? (It's not used for link hovering) > > > > > > (I know it's in the WK2 C API, but does anyone know of an example web app/site that uses window.status that works?) > > > > Interesting point. It seems that "window.status" itself is not expected to work in HTML5 (even though WebKit supports it). > > > > http://dev.w3.org/html5/spec/Overview.html#dom-window-status > > To be honest, I discovered this feature when I've worked on this bug. Never heard about it before and I'm afraid this can't be very useful as well. If we want to at least support this feature, then maybe we should just have the signal as we had before? The test case could be modified a bit. This is a great reason for removing the API altogether.
Simon Hausmann
Comment 7 2011-12-19 06:05:47 PST
Comment on attachment 119086 [details] Patch r- as it turns out that we should rather remove the status message API altogether.
Simon Hausmann
Comment 8 2011-12-20 06:20:15 PST
Adjusting title to latest conclusions ;-)
Simon Hausmann
Comment 9 2011-12-20 06:24:00 PST
Created attachment 120020 [details] Patch
WebKit Review Bot
Comment 10 2011-12-20 13:40:57 PST
Comment on attachment 120020 [details] Patch Clearing flags on attachment: 120020 Committed r103347: <http://trac.webkit.org/changeset/103347>
WebKit Review Bot
Comment 11 2011-12-20 13:41:02 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.