RESOLVED FIXED 73580
Rollout r101743 
https://bugs.webkit.org/show_bug.cgi?id=73580
Summary Rollout r101743
Raphael Kubo da Costa (:rakuco)
Reported 2011-12-01 11:59:04 PST
As mentioned in https://bugs.webkit.org/show_bug.cgi?id=73111#c25, linking of the Tools/ targets (EWebLauncher, DumpRenderTree and ImageDiff) is broken with r101347: ../../../Source/WebCore/libwebcore_efl.so.0.1.0: undefined reference to `WebCore::uidForImage(WebCore::Image*)' ../../../Source/WebCore/libwebcore_efl.so.0.1.0: undefined reference to `WebCore::BGRA32PremultimpliedBuffer::create()' collect2: ld returned 1 exit status These functions are implemented in TextureMapperQt.cpp. Alternatively, one might be interested in sharing TextureMapperCairo with GTK+ (it got committed not long ago).
Attachments
Patch (10.16 KB, patch)
2011-12-01 12:14 PST, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Rebased patch for landing (10.22 KB, patch)
2011-12-02 06:02 PST, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1 2011-12-01 12:14:14 PST
Created attachment 117455 [details] Patch
WebKit Review Bot
Comment 2 2011-12-02 04:16:12 PST
Comment on attachment 117455 [details] Patch Rejecting attachment 117455 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: - saving rejects to file Source/WebCore/platform/graphics/GraphicsLayer.h.rej patching file Source/WebCore/platform/graphics/efl/GraphicsLayerEfl.cpp patching file Source/WebCore/platform/graphics/efl/GraphicsLayerEfl.h patching file Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp patching file Source/cmake/OptionsEfl.cmake patching file ChangeLog Hunk #1 succeeded at 1 with fuzz 3. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/10727124
Raphael Kubo da Costa (:rakuco)
Comment 3 2011-12-02 06:02:55 PST
Created attachment 117614 [details] Rebased patch for landing
WebKit Review Bot
Comment 4 2011-12-02 07:32:21 PST
Comment on attachment 117614 [details] Rebased patch for landing Clearing flags on attachment: 117614 Committed r101796: <http://trac.webkit.org/changeset/101796>
WebKit Review Bot
Comment 5 2011-12-02 07:32:25 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.