Created attachment 117381 [details] Patch

Please capitalise the first character of the bug title.

Created attachment 117387 [details] Patch

Comment on attachment 117387 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117387&action=review > Source/WebCore/ChangeLog:6 > + Upstream 5 files into WebCore/platform/blackberry > + https://bugs.webkit.org/show_bug.cgi?id=73541 > + > + Reviewed by NOBODY (OOPS!). You could write at least one line about the content and sense of the files :) > Source/WebCore/platform/blackberry/PlatformScreenBlackBerry.cpp:46 > + return FloatRect(FloatPoint(0, 0), FloatSize(IntSize(BlackBerry::Platform::Graphics::Screen::size()))); just FloatPoint() > Source/WebCore/platform/blackberry/PlatformScreenBlackBerry.cpp:51 > + return FloatRect(FloatPoint(0, 0), FloatSize(IntSize(BlackBerry::Platform::Graphics::Screen::size()))); Ditto.

(In reply to comment #4) > (From update of attachment 117387 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=117387&action=review > > > Source/WebCore/ChangeLog:6 > > + Upstream 5 files into WebCore/platform/blackberry > > + https://bugs.webkit.org/show_bug.cgi?id=73541 > > + > > + Reviewed by NOBODY (OOPS!). > > You could write at least one line about the content and sense of the files :) > > > Source/WebCore/platform/blackberry/PlatformScreenBlackBerry.cpp:46 > > + return FloatRect(FloatPoint(0, 0), FloatSize(IntSize(BlackBerry::Platform::Graphics::Screen::size()))); > > just FloatPoint() > > > Source/WebCore/platform/blackberry/PlatformScreenBlackBerry.cpp:51 > > + return FloatRect(FloatPoint(0, 0), FloatSize(IntSize(BlackBerry::Platform::Graphics::Screen::size()))); > > Ditto. OK, thanks for your comments, will update...

Created attachment 117824 [details] Patch

Comment on attachment 117824 [details] Patch Attachment 117824 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10728575 New failing tests: svg/custom/linking-uri-01-b.svg

(In reply to comment #7) > (From update of attachment 117824 [details]) > Attachment 117824 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/10728575 > > New failing tests: > svg/custom/linking-uri-01-b.svg it's blackberry specific porting, shouldn't impact chrome test/build.

Comment on attachment 117824 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117824&action=review Looking quite good, some small stuff left, so r- for now. > Source/WebCore/platform/blackberry/PlatformScreenBlackBerry.cpp:44 > +FloatRect screenAvailableRect(Widget* widget) widget not used, so can be removed. > Source/WebCore/platform/blackberry/PlatformScreenBlackBerry.cpp:49 > +FloatRect screenRect(Widget* widget) Ditto. > Source/WebCore/platform/blackberry/SSLKeyGeneratorBlackBerry.cpp:27 > + Extra empty line not needed. > Source/WebCore/platform/blackberry/SSLKeyGeneratorBlackBerry.cpp:30 > +void getSupportedKeySizes(Vector<String>& sizes) sizes not used, so can be removed. > Source/WebCore/platform/blackberry/WidgetBlackBerry.cpp:27 > +#include "ScrollView.h" Is ScrollView include needed?

Thanks, Rob. All comments accepted, except: >> Source/WebCore/platform/blackberry/WidgetBlackBerry.cpp:27 >> +#include "ScrollView.h" >Is ScrollView include needed? ScrollView was needed in line 12. PlatformPageClient pageClient = root()->hostWindow()->platformPageClient(); root() was ScrollView, so can't remove the header file. And looks WheelEventBlackBerry.cpp was an empty file, so I removed from makefile list. Pls see update patch...thanks

Created attachment 118313 [details] Patch

Comment on attachment 118313 [details] Patch Clearing flags on attachment: 118313 Committed r102314: <http://trac.webkit.org/changeset/102314>

All reviewed patches have been landed. Closing bug.