WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
73106
Fix the current working directory of run-bindings-tests
https://bugs.webkit.org/show_bug.cgi?id=73106
Summary
Fix the current working directory of run-bindings-tests
Kentaro Hara
Reported
2011-11-24 21:20:18 PST
Currently, run-bindings-tests outputs the following error (although it outputs "all tests passed!" in the end): Testing the ObjC generator on TestObj.idl gcc: WebCore/bindings/objc/PublicDOMInterfaces.h: No such file or directory gcc: warning: '-x objective-c' after last input file has no effect gcc: no input files This is because CodeGeneratorObjC.pm assumes that the current working directory is WebKit/Source/, but run-bindings-tests sets the current working directory to WebKit/. We should change it to WebKit/Source/. Incidentally, fixing run-bindings-tests are more reasonable than fixing CodeGeneratorObjC.pm, since real build scripts (e.g. WebCore.gyp) run with the assumption that the current working directory is WebKit/Source/.
Attachments
Patch
(2.91 KB, patch)
2011-11-24 21:24 PST
,
Kentaro Hara
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2011-11-24 21:23:17 PST
I see.
Kentaro Hara
Comment 2
2011-11-24 21:24:16 PST
Created
attachment 116557
[details]
Patch
WebKit Review Bot
Comment 3
2011-11-24 22:36:45 PST
Comment on
attachment 116557
[details]
Patch Clearing flags on attachment: 116557 Committed
r101149
: <
http://trac.webkit.org/changeset/101149
>
WebKit Review Bot
Comment 4
2011-11-24 22:36:50 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug