WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
72552
Unset the active flag when TextTrackCues go away
https://bugs.webkit.org/show_bug.cgi?id=72552
Summary
Unset the active flag when TextTrackCues go away
Anna Cavender
Reported
2011-11-16 14:49:16 PST
4.8.10.12.1 Text track model
http://www.whatwg.org/specs/web-apps/current-work/#text-track-cue-active-flag
The active flag … The user agent must synchronously unset this flag whenever the text track cue is removed from its text track's text track list of cues; whenever the text track itself is removed from its media element's list of text tracks or has its text track mode changed to disabled; and whenever the media element's readyState is changed back to HAVE_NOTHING. When the flag is unset in this way for one or more cues in text tracks that were showing or showing by default prior to the relevant incident, the user agent must, after having unset the flag for all the affected cues, apply the rules for updating the text track rendering of those text tracks. For example, for text tracks based on WebVTT, the rules for updating the display of WebVTT text tracks.
Attachments
Proposed patch
(6.81 KB, patch)
2012-02-07 14:41 PST
,
Eric Carlson
webkit.review.bot
: commit-queue-
Details
Formatted Diff
Diff
Updated patch.
(9.64 KB, patch)
2012-02-09 13:18 PST
,
Eric Carlson
mjs
: review+
webkit.review.bot
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2011-11-17 12:39:09 PST
<
rdar://problem/10464476
>
Eric Carlson
Comment 2
2012-02-07 14:41:45 PST
Created
attachment 125930
[details]
Proposed patch
Eric Carlson
Comment 3
2012-02-07 14:43:50 PST
We already clear a cue's active flag when it is removed from the track, and existing tests check that. We were not clearing active flags when the media element's readyState is set to HAVE_NOTHING, this patch does that.
WebKit Review Bot
Comment 4
2012-02-07 15:41:18 PST
Comment on
attachment 125930
[details]
Proposed patch
Attachment 125930
[details]
did not pass chromium-ews (chromium-xvfb): Output:
http://queues.webkit.org/results/11460118
New failing tests: media/track/track-cue-mutable-text.html media/track/track-active-cues.html
Eric Carlson
Comment 5
2012-02-09 13:18:10 PST
Created
attachment 126357
[details]
Updated patch.
WebKit Review Bot
Comment 6
2012-02-09 13:55:41 PST
Comment on
attachment 126357
[details]
Updated patch.
Attachment 126357
[details]
did not pass chromium-ews (chromium-xvfb): Output:
http://queues.webkit.org/results/11480402
New failing tests: media/track/track-cue-mutable-text.html
Maciej Stachowiak
Comment 7
2012-02-09 14:56:34 PST
Comment on
attachment 126357
[details]
Updated patch. Code change looks good to me, but please check why media/track/track-cue-mutable-text.html is failing on cr-linux. Maybe it just needs to be skipped. Conditional r+ assuming that test failure can be fixed.
Eric Carlson
Comment 8
2012-02-15 12:04:52 PST
http://trac.webkit.org/changeset/107831
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug