RESOLVED FIXED 68018
Remove ENABLE_SVG_FOREIGN_OBJECT as it is a required part of HTML5 
https://bugs.webkit.org/show_bug.cgi?id=68018
Summary Remove ENABLE_SVG_FOREIGN_OBJECT as it is a required part of HTML5
Eric Seidel (no email)
Reported 2011-09-13 11:57:24 PDT
Remove ENABLE_SVG_FOREIGN_OBJECT as its a required part of HTML5
Attachments
Patch (45.08 KB, patch)
2011-09-13 11:59 PDT, Eric Seidel (no email) 		rniwa: review+
rniwa: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-09-13 11:59:47 PDT
Created attachment 107207 [details] Patch
Ryosuke Niwa
Comment 2 2011-09-13 13:06:20 PDT
Comment on attachment 107207 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107207&action=review > Source/WebKit2/Configurations/FeatureDefines.xcconfig:102 > +FEATURE_DEFINES = $(ENABLE_3D_RENDERING) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ANIMATION_API) $(ENABLE_BLOB) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CLIENT_BASED_GEOLOCATION) $(ENABLE_CSS3_FLEXBOX) $(ENABLE_DATABASE) $(ENABLE_DATALIST) $(ENABLE_DATA_TRANSFER_ITEMS) $(ENABLE_DETAILS) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DIRECTORY_UPLOAD) $(ENABLE_DOM_STORAGE) $(ENABLE_EVENTSOURCE) $(ENABLE_FILE_SYSTEM) $(ENABLE_FILTERS) $(ENABLE_FULLSCREEN_API) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENAwarning: LF will be replaced by CRLF in WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops. What's up with "warning: LF will be replaced by CRLF in WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops."?
Daniel Bates
Comment 3 2011-09-13 13:10:14 PDT
Comment on attachment 107207 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107207&action=review > Tools/Scripts/build-webkit:-286 > - define => "ENABLE_SVG_FOREIGN_OBJECT", default => 1, value => \$svgForeignObjectSupport }, You should also remove the variable $svgForeignObjectSupport, which is also referenced on <http://trac.webkit.org/browser/trunk/Tools/Scripts/build-webkit#L360>. I see that you made these changes in the patch for bug #68019. That being said, it would have been better to have made these changes in this patch since the purpose of this patch is to remove ENABLE_SVG_FOREIGN_OBJECT support whereas the purpose of the patch for bug #68019 is to remove ENABLE_SVG_USE support.
Eric Seidel (no email)
Comment 4 2011-09-13 13:18:38 PDT
Committed r95040: <http://trac.webkit.org/changeset/95040>
Note You need to log in before you can comment on or make changes to this bug.