RESOLVED FIXED 65170
[Qt] Fix tst_QWebFrame::connectAndDisconnect() API test 
https://bugs.webkit.org/show_bug.cgi?id=65170
Summary [Qt] Fix tst_QWebFrame::connectAndDisconnect() API test
Kristóf Kosztyó
Reported 2011-07-26 04:17:51 PDT
FAIL! : tst_QWebFrame::connectAndDisconnect() Compared values are not the same Actual (evalJS("slotThisObject == window")): false Expected (sTrue): true Loc: [/ramdisk/qt-linux-release/build/Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp(1455)] It started failing after r91095
Attachments
mark failing test cases as expected fail (3.77 KB, patch)
2011-08-02 05:07 PDT, Kristóf Kosztyó 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kristóf Kosztyó
Comment 1 2011-07-29 03:58:31 PDT
this testcases also fail FAIL! : tst_QWebFrame::connectAndDisconnect() Compared values are not the same Actual (evalJS("myObject.mySignalWithIntArg(123)")): 123 Expected (sUndefined): undefined Loc: [/home/kosztyo/WebKit/Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp(1563)] QDEBUG : tst_QWebFrame::classEnums() can't make "generic.orientation" because no QAccelerometer sensors exist FAIL! : tst_QWebFrame::connectAndDisconnect() Compared values are not the same Actual (evalJS("myObject.mySignalWithIntArg(123)")): 123 Expected (sUndefined): undefined Loc: [/home/kosztyo/WebKit/Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp(1572)] QDEBUG : tst_QWebFrame::classEnums() can't make "generic.orientation" because no QAccelerometer sensors exist FAIL! : tst_QWebFrame::connectAndDisconnect() Compared values are not the same Actual (evalJS("myObject.mySignalWithIntArg(123)")): 123 Expected (sUndefined): undefined Loc: [/home/kosztyo/WebKit/Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp(1581)] QDEBUG : tst_QWebFrame::classEnums() can't make "generic.orientation" because no QAccelerometer sensors exist FAIL! : tst_QWebFrame::connectAndDisconnect() Compared values are not the same Actual (evalJS("myObject.mySignalWithIntArg(123)")): 123 Expected (sUndefined): undefined Loc: [/home/kosztyo/WebKit/Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp(1591)] QDEBUG : tst_QWebFrame::classEnums() can't make "generic.orientation" because no QAccelerometer sensors exist FAIL! : tst_QWebFrame::connectAndDisconnect() Compared values are not the same Actual (evalJS("myObject.mySignalWithIntArg(456)")): 456 Expected (sUndefined): undefined Loc: [/home/kosztyo/WebKit/Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp(1600)] QDEBUG : tst_QWebFrame::classEnums() can't make "generic.orientation" because no QAccelerometer sensors exist
Csaba Osztrogonác
Comment 2 2011-08-02 01:53:55 PDT
Could you mark them as expected fails?
Kristóf Kosztyó
Comment 3 2011-08-02 05:07:05 PDT
Created attachment 102634 [details] mark failing test cases as expected fail
Csaba Osztrogonác
Comment 4 2011-08-02 05:11:46 PDT
Comment on attachment 102634 [details] mark failing test cases as expected fail r=me
Csaba Osztrogonác
Comment 5 2011-08-02 05:14:56 PDT
Comment on attachment 102634 [details] mark failing test cases as expected fail Landed in https://trac.webkit.org/changeset/92180
Csaba Osztrogonác
Comment 6 2012-11-14 04:37:17 PST
Tests were unskipped long time ago, so it is fixed.
Note You need to log in before you can comment on or make changes to this bug.