RESOLVED FIXED 63171
Convert SVGPointList to SVGAnimatorFactory concept 
https://bugs.webkit.org/show_bug.cgi?id=63171
Summary Convert SVGPointList to SVGAnimatorFactory concept
Dirk Schulze
Reported 2011-06-22 12:58:07 PDT
Convert SVGPointList to SVGAnimatorFactory concept.
Attachments
Patch (32.74 KB, patch)
2011-06-22 13:15 PDT, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
Patch (40.14 KB, patch)
2011-06-22 13:55 PDT, Dirk Schulze 		rwlbuis: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dirk Schulze
Comment 1 2011-06-22 13:15:31 PDT
Created attachment 98227 [details] Patch
WebKit Review Bot
Comment 2 2011-06-22 13:24:16 PDT
Comment on attachment 98227 [details] Patch Attachment 98227 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8924674
Early Warning System Bot
Comment 3 2011-06-22 13:33:28 PDT
Comment on attachment 98227 [details] Patch Attachment 98227 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/8921756
Dirk Schulze
Comment 4 2011-06-22 13:55:29 PDT
Created attachment 98236 [details] Patch
Rob Buis
Comment 5 2011-06-22 14:38:55 PDT
Comment on attachment 98236 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98236&action=review LGTM > Source/WebCore/WebCore.xcodeproj/project.pbxproj:999 > + 43B9336A13B261B1004584BF /* SVGAnimatedPointList.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 43B9336813B261B1004584BF /* SVGAnimatedPointList.cpp */; }; You may want to sort this. > Source/WebCore/svg/SVGAnimatedPointList.cpp:86 > + animatedPointList = ((animationMode == FromToAnimation && percentage > 0.5f) || animationMode == ToAnimation || percentage == 1) 0.5f -> 0.5
Dirk Schulze
Comment 6 2011-06-22 23:32:23 PDT
Committed r89536: <http://trac.webkit.org/changeset/89536>
Note You need to log in before you can comment on or make changes to this bug.