RESOLVED FIXED 62859
Exclude isCALayerContext check if building Chrome to use Skia on Mac. 
https://bugs.webkit.org/show_bug.cgi?id=62859
Summary Exclude isCALayerContext check if building Chrome to use Skia on Mac.
Cary Clark
Reported 2011-06-17 06:30:43 PDT
Exclude isCALayerContext check if building Chrome to use Skia on Mac.
Attachments
Patch (1.71 KB, patch)
2011-06-17 06:33 PDT, Cary Clark 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Cary Clark
Comment 1 2011-06-17 06:33:39 PDT
Created attachment 97590 [details] Patch
Mihai Parparita
Comment 2 2011-06-17 10:05:22 PDT
I'm not that familiar with the Mac Skia efforts. Would it be safer (in case there are other callsites) to change GraphicsContext.h to add a declaration of isCALayerContext when USE(SKIA) is defined to always return false?
Cary Clark
Comment 3 2011-06-17 10:35:44 PDT
This is the only call-site. Eventually, the code will become scrollAnimator->setIsDrawingIntoLayer(false); (no compile-time condition) once all Skia patches are landed, so there's little value in adding a dummy isCALayerContext() call.
Cary Clark
Comment 4 2011-06-17 10:36:27 PDT
(that is, this is the only call-site that is compiled when USE(SKIA) is defined on the Chromium Mac build.)
WebKit Review Bot
Comment 5 2011-06-17 11:12:32 PDT
The commit-queue encountered the following flaky tests while processing attachment 97590 [details]: fast/dom/NodeList/5725058-crash-scenario-1.html bug 62577 (authors: mrowe@apple.com and sam@webkit.org) The commit-queue is continuing to process your patch.
WebKit Review Bot
Comment 6 2011-06-17 11:13:58 PDT
Comment on attachment 97590 [details] Patch Clearing flags on attachment: 97590 Committed r89147: <http://trac.webkit.org/changeset/89147>
WebKit Review Bot
Comment 7 2011-06-17 11:14:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.