RESOLVED FIXED 62603
Run run-api-tests on bots in debug mode 
https://bugs.webkit.org/show_bug.cgi?id=62603
Summary Run run-api-tests on bots in debug mode
Dmitry Lomov
Reported 2011-06-13 15:06:18 PDT
Make sure TestWebKitAPI runs on bots in debug mode at least. (61812 prevents us from running in release mode yet)
Attachments
Proposed fix (2.08 KB, patch)
2011-06-13 15:14 PDT, Dmitry Lomov 		no flags
DetailsFormatted DiffDiff
Added comment explaining why debug mode only (2.27 KB, patch)
2011-06-13 15:25 PDT, Dmitry Lomov 		slewis: review+
DetailsFormatted DiffDiff
BuildAndTestFactory fixed (2.27 KB, patch)
2011-06-15 17:47 PDT, Dmitry Lomov 		levin: review-
DetailsFormatted DiffDiff
Uploading correct patch this time (2.39 KB, patch)
2011-06-16 09:44 PDT, Dmitry Lomov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Dmitry Lomov
Comment 1 2011-06-13 15:14:29 PDT
Created attachment 97015 [details] Proposed fix
Eric Seidel (no email)
Comment 2 2011-06-13 15:17:52 PDT
Comment on attachment 97015 [details] Proposed fix Why only debug mode?
Eric Seidel (no email)
Comment 3 2011-06-13 15:18:29 PDT
Comment on attachment 97015 [details] Proposed fix I see. We should add a comment pointing to the bug which blocks running them in release mode. Otherwise this looks OK.
Dmitry Lomov
Comment 4 2011-06-13 15:25:48 PDT
Created attachment 97017 [details] Added comment explaining why debug mode only
David Levin
Comment 5 2011-06-15 17:23:01 PDT
Comment on attachment 97017 [details] Added comment explaining why debug mode only This looks good to me. If no one else has objections, I'll r+ it tomorrow. Thanks!
Stephanie Lewis
Comment 6 2011-06-15 17:30:08 PDT
Comment on attachment 97017 [details] Added comment explaining why debug mode only View in context: https://bugs.webkit.org/attachment.cgi?id=97017&action=review Jus the one question, otherwise r=me > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:556 > + self.addStep(RunUnitTests) How come we don't need to check for debug here?
Dmitry Lomov
Comment 7 2011-06-15 17:32:13 PDT
Comment on attachment 97017 [details] Added comment explaining why debug mode only View in context: https://bugs.webkit.org/attachment.cgi?id=97017&action=review >> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:556 >> + self.addStep(RunUnitTests) > > How come we don't need to check for debug here? Oh right - good catch! Do we have bots that both build and test?
Stephanie Lewis
Comment 8 2011-06-15 17:38:05 PDT
Yes. SnowLeopard Leaks, some QT and GTK bots, and some of the Chromium new-run-webkit-tests bots.
Dmitry Lomov
Comment 9 2011-06-15 17:47:17 PDT
Created attachment 97378 [details] BuildAndTestFactory fixed
David Levin
Comment 10 2011-06-15 19:22:41 PDT
Comment on attachment 97378 [details] BuildAndTestFactory fixed Something must be wrong. There is no change between this patch and the previous one.
Dmitry Lomov
Comment 11 2011-06-16 09:44:34 PDT
Created attachment 97453 [details] Uploading correct patch this time Ugh - sorry for the noise - I do not know what happened.
WebKit Review Bot
Comment 12 2011-06-16 11:46:55 PDT
Comment on attachment 97453 [details] Uploading correct patch this time Clearing flags on attachment: 97453 Committed r89054: <http://trac.webkit.org/changeset/89054>
WebKit Review Bot
Comment 13 2011-06-16 11:47:00 PDT
All reviewed patches have been landed. Closing bug.
Ryosuke Niwa
Comment 14 2011-06-17 17:09:42 PDT
api tests are failing on SL debug tests after this patch was landed: http://build.webkit.org/builders/SnowLeopard%20Intel%20Debug%20%28Tests%29/builds/723
Daniel Bates
Comment 15 2011-06-17 17:22:02 PDT
Comment on attachment 97453 [details] Uploading correct patch this time View in context: https://bugs.webkit.org/attachment.cgi?id=97453&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:316 > + command = ["perl", "./Tools/Scripts/run-api-tests"] We should pass the configuration (i.e. Debug/Release) to run-api-tests so that it can call build-api-tests with this configuration.
Daniel Bates
Comment 16 2011-06-17 17:23:04 PDT
(In reply to comment #15) > We should pass the configuration (i.e. Debug/Release) to run-api-tests so that it can call build-api-tests with this configuration. Dmitry Lomov filed bug #62918 with regards to this issue.
Note You need to log in before you can comment on or make changes to this bug.