61694 – WebKit2: Enable serializing of data types needed for cross-process accelerated compositing

RESOLVED FIXED 61694

WebKit2: Enable serializing of data types needed for cross-process accelerated compositing

https://bugs.webkit.org/show_bug.cgi?id=61694

Summary WebKit2: Enable serializing of data types needed for cross-process accelerate...

Noam Rosenthal

Reported 2011-05-28 15:00:11 PDT

This is the first part of upstreaming the cross-process accelerated-compositing implementation we use with Qt. To enable accelerated compositing on the UI process, we need to serialize the following: * TransformationMatrix * TimingFunction * TransformOperation[s] * Animation * The GraphicsLayer data As a first measure, we'll enable ArgumentCoders for relevant existing data types.

Attachments
Patch 1: enable Length/TransformationMatrix via SimpleArgumentCoder (3.14 KB, patch) 2011-05-29 09:13 PDT, Noam Rosenthal	no flags	Details Formatted Diff Diff
Patch 2: Serialize TimingFunction (7.09 KB, patch) 2011-05-29 11:25 PDT, Noam Rosenthal	no flags	Details Formatted Diff Diff
Patch 3: ArgumentCoder for WebCore::Animation (8.26 KB, patch) 2011-05-29 15:25 PDT, Noam Rosenthal	commit-queue: commit-queue-	Details Formatted Diff Diff
Patch 4: TransformOperation[s] (12.78 KB, patch) 2011-05-29 21:03 PDT, Noam Rosenthal	no flags	Details Formatted Diff Diff
Patch 1: enable Length/TransformationMatrix via SimpleArgumentCoder (2.90 KB, patch) 2011-05-30 09:53 PDT, Noam Rosenthal	commit-queue: commit-queue-	Details Formatted Diff Diff
Patch 2: Serialize TimingFunction (5.90 KB, patch) 2011-05-30 10:10 PDT, Noam Rosenthal	commit-queue: commit-queue-	Details Formatted Diff Diff
Patch 3: ArgumentCoder for WebCore::Animation (7.76 KB, patch) 2011-05-30 10:39 PDT, Noam Rosenthal	no flags	Details Formatted Diff Diff
Patch 1: enable Length/TransformationMatrix via SimpleArgumentCoder (2.90 KB, patch) 2011-05-30 12:37 PDT, Noam Rosenthal	no flags	Details Formatted Diff Diff
Patch 2: Serialize TimingFunction (5.90 KB, patch) 2011-05-30 13:32 PDT, Noam Rosenthal	no flags	Details Formatted Diff Diff
Patch for landing (6.01 KB, patch) 2011-05-30 15:41 PDT, Noam Rosenthal	no flags	Details Formatted Diff Diff
Patch 3: ArgumentCoder for WebCore::Animation (7.76 KB, patch) 2011-05-30 16:51 PDT, Noam Rosenthal	no flags	Details Formatted Diff Diff
Patch 4: TransformOperation[s] (11.75 KB, patch) 2011-06-06 22:40 PDT, Noam Rosenthal	no flags	Details Formatted Diff Diff
Patch (2.13 KB, patch) 2011-06-06 22:46 PDT, Noam Rosenthal	no flags	Details Formatted Diff Diff
Patch 4: TransformOperation[s] (11.75 KB, patch) 2011-06-06 22:52 PDT, Noam Rosenthal	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Patch (12.86 KB, patch) 2011-06-08 10:47 PDT, Noam Rosenthal	no flags	Details Formatted Diff Diff
Patch 4: TransformOperation[s] (18.45 KB, patch) 2011-06-08 12:17 PDT, Noam Rosenthal	no flags	Details Formatted Diff Diff
Patch (2.48 KB, patch) 2011-06-08 13:19 PDT, Noam Rosenthal	no flags	Details Formatted Diff Diff
Last patch: KeyframeValueList coder (6.84 KB, patch) 2011-06-08 18:06 PDT, Noam Rosenthal	no flags	Details Formatted Diff Diff
Show Obsolete (16) View All Add attachment proposed patch, testcase, etc.

Noam Rosenthal

Comment 1 2011-05-29 09:13:17 PDT

Created attachment 95287 [details] Patch 1: enable Length/TransformationMatrix via SimpleArgumentCoder

Noam Rosenthal

Comment 2 2011-05-29 11:25:47 PDT

Created attachment 95289 [details] Patch 2: Serialize TimingFunction

Noam Rosenthal

Comment 3 2011-05-29 15:25:10 PDT

Created attachment 95304 [details] Patch 3: ArgumentCoder for WebCore::Animation

WebKit Commit Bot

Comment 4 2011-05-29 16:21:00 PDT

Comment on attachment 95304 [details] Patch 3: ArgumentCoder for WebCore::Animation Attachment 95304 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/8747583

Noam Rosenthal

Comment 5 2011-05-29 16:26:36 PDT

(In reply to comment #4) > (From update of attachment 95304 [details]) > Attachment 95304 [details] did not pass mac-ews (mac): > Output: http://queues.webkit.org/results/8747583 This relies on the other patches to compile. It should still be reviewable.

Noam Rosenthal

Comment 6 2011-05-29 21:03:12 PDT

Created attachment 95320 [details] Patch 4: TransformOperation[s]

Adam Roben (:aroben)

Comment 7 2011-05-30 08:31:31 PDT

Noam Rosenthal

Comment 8 2011-05-30 09:30:14 PDT

(In reply to comment #7) > (From update of attachment 95287 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=95287&action=review > > > Source/WebKit2/Scripts/webkit2/messages.py:447 > > + 'WebCore::Length': '<WebCore/Length.h>', > > I thought the scripts knew how to infer this. My understanding was that headers_for_type only needed to be modified if the header did not match the namespace/class name. This is needed, otherwise the headers don't get copied to the include/WebCore directory.

Adam Roben (:aroben)

Comment 9 2011-05-30 09:32:06 PDT

Comment on attachment 95287 [details] Patch 1: enable Length/TransformationMatrix via SimpleArgumentCoder View in context: https://bugs.webkit.org/attachment.cgi?id=95287&action=review >>> Source/WebKit2/Scripts/webkit2/messages.py:447 >>> + 'WebCore::Length': '<WebCore/Length.h>', >> >> I thought the scripts knew how to infer this. My understanding was that headers_for_type only needed to be modified if the header did not match the namespace/class name. > > This is needed, otherwise the headers don't get copied to the include/WebCore directory. How does this script affect what headers get copied? All it's supposed to do is write generated source files.

Noam Rosenthal

Comment 10 2011-05-30 09:43:01 PDT

> > This is needed, otherwise the headers don't get copied to the include/WebCore directory. > > How does this script affect what headers get copied? All it's supposed to do is write generated source files. OK, It's needed in the script but it can be added to a different part of the script (not to special_cases). I'll amend before committing.

Noam Rosenthal

Comment 11 2011-05-30 09:52:04 PDT

Noam Rosenthal

Comment 12 2011-05-30 09:53:38 PDT

Created attachment 95349 [details] Patch 1: enable Length/TransformationMatrix via SimpleArgumentCoder

Noam Rosenthal

Comment 13 2011-05-30 10:10:41 PDT

Created attachment 95350 [details] Patch 2: Serialize TimingFunction

Noam Rosenthal

Comment 14 2011-05-30 10:39:41 PDT

Created attachment 95354 [details] Patch 3: ArgumentCoder for WebCore::Animation

WebKit Commit Bot

Comment 15 2011-05-30 12:06:01 PDT

Comment on attachment 95350 [details] Patch 2: Serialize TimingFunction Rejecting attachment 95350 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'apply-..." exit_code: 2 Last 500 characters of output: tching file Source/WebKit2/Scripts/webkit2/messages.py Hunk #1 FAILED at 258. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit2/Scripts/webkit2/messages.py.rej patching file Source/WebKit2/Shared/WebCoreArgumentCoders.h Hunk #1 FAILED at 48. Hunk #2 succeeded at 481 (offset -5 lines). 1 out of 2 hunks FAILED -- saving rejects to file Source/WebKit2/Shared/WebCoreArgumentCoders.h.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/8747754

WebKit Commit Bot

Comment 16 2011-05-30 12:30:29 PDT

Comment on attachment 95349 [details] Patch 1: enable Length/TransformationMatrix via SimpleArgumentCoder Rejecting attachment 95349 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'land-a..." exit_code: 1 Last 500 characters of output: pe=xml Processing 1 patch from 1 bug. Cleaning working directory Updating working directory Processing patch 95349 from bug 61694. Simon Haussman found in /mnt/git/webkit-commit-queue/Source/WebKit2/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /mnt/git/webkit-commit-queue/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Updating OpenSource Current branch master is up to date. Full output: http://queues.webkit.org/results/8751503

Noam Rosenthal

Comment 17 2011-05-30 12:37:48 PDT

Created attachment 95360 [details] Patch 1: enable Length/TransformationMatrix via SimpleArgumentCoder

Noam Rosenthal

Comment 18 2011-05-30 13:32:40 PDT

Created attachment 95366 [details] Patch 2: Serialize TimingFunction

WebKit Commit Bot

Comment 19 2011-05-30 13:58:43 PDT

Comment on attachment 95366 [details] Patch 2: Serialize TimingFunction Rejecting attachment 95366 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'apply-..." exit_code: 2 Last 500 characters of output: tching file Source/WebKit2/Scripts/webkit2/messages.py Hunk #1 FAILED at 258. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit2/Scripts/webkit2/messages.py.rej patching file Source/WebKit2/Shared/WebCoreArgumentCoders.h Hunk #1 FAILED at 48. Hunk #2 succeeded at 481 (offset -5 lines). 1 out of 2 hunks FAILED -- saving rejects to file Source/WebKit2/Shared/WebCoreArgumentCoders.h.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/8753229

WebKit Commit Bot

Comment 20 2011-05-30 15:03:08 PDT

Comment on attachment 95360 [details] Patch 1: enable Length/TransformationMatrix via SimpleArgumentCoder Clearing flags on attachment: 95360 Committed r87699: <http://trac.webkit.org/changeset/87699>

WebKit Review Bot

Comment 21 2011-05-30 15:09:17 PDT

Attachment 95366 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit2/Shared/WebCoreArgumentCoders.h:499: Non-label code inside switch statements should be indented. [whitespace/indent] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.

Noam Rosenthal

Comment 22 2011-05-30 15:41:03 PDT

Created attachment 95377 [details] Patch for landing

WebKit Commit Bot

Comment 23 2011-05-30 16:44:11 PDT

Comment on attachment 95377 [details] Patch for landing Clearing flags on attachment: 95377 Committed r87701: <http://trac.webkit.org/changeset/87701>

Noam Rosenthal

Comment 24 2011-05-30 16:51:46 PDT

Created attachment 95381 [details] Patch 3: ArgumentCoder for WebCore::Animation

WebKit Commit Bot

Comment 25 2011-05-30 19:22:01 PDT

Comment on attachment 95381 [details] Patch 3: ArgumentCoder for WebCore::Animation Clearing flags on attachment: 95381 Committed r87707: <http://trac.webkit.org/changeset/87707>

Noam Rosenthal

Comment 26 2011-06-06 22:40:21 PDT

Created attachment 96206 [details] Patch 4: TransformOperation[s]

WebKit Review Bot

Comment 27 2011-06-06 22:42:01 PDT

Attachment 96206 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/Shared/WebCoreArgumentCoders.h:49: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit2/Shared/WebCoreArgumentCoders.h:62: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.

Noam Rosenthal

Comment 28 2011-06-06 22:46:37 PDT

Created attachment 96209 [details] Patch

Noam Rosenthal

Comment 29 2011-06-06 22:52:49 PDT

Created attachment 96210 [details] Patch 4: TransformOperation[s]

WebKit Review Bot

Comment 30 2011-06-06 23:20:27 PDT

Comment on attachment 96210 [details] Patch 4: TransformOperation[s] Clearing flags on attachment: 96210 Committed r88222: <http://trac.webkit.org/changeset/88222>

Noam Rosenthal

Comment 31 2011-06-07 09:36:24 PDT

Not sure why this (In reply to comment #30) > (From update of attachment 96210 [details]) > Clearing flags on attachment: 96210 > > Committed r88222: <http://trac.webkit.org/changeset/88222> Not sure why this broke the Mac build; It builds fine for me. It seems like I'm not putting the transform operation headers in the right place in the python script, but I'm not sure where they're supposed to go.

WebKit Review Bot

Comment 32 2011-06-07 22:10:44 PDT

Comment on attachment 96210 [details] Patch 4: TransformOperation[s] Attachment 96210 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/8810032

Noam Rosenthal

Comment 33 2011-06-08 10:47:08 PDT

Created attachment 96440 [details] Patch

Noam Rosenthal

Comment 34 2011-06-08 12:17:21 PDT

Created attachment 96457 [details] Patch 4: TransformOperation[s]

Noam Rosenthal

Comment 35 2011-06-08 12:19:23 PDT

(In reply to comment #34) > Created an attachment (id=96457) [details] > Patch 4: TransformOperation[s] This includes some build fixes for Mac.

WebKit Review Bot

Comment 36 2011-06-08 13:07:22 PDT

Comment on attachment 96457 [details] Patch 4: TransformOperation[s] Clearing flags on attachment: 96457 Committed r88378: <http://trac.webkit.org/changeset/88378>

WebKit Review Bot

Comment 37 2011-06-08 13:07:29 PDT

All reviewed patches have been landed. Closing bug.

Noam Rosenthal

Comment 38 2011-06-08 13:15:17 PDT

Not done yet... :)

Noam Rosenthal

Comment 39 2011-06-08 13:19:34 PDT

Created attachment 96469 [details] Patch

WebKit Review Bot

Comment 40 2011-06-08 14:53:54 PDT

Comment on attachment 96469 [details] Patch Clearing flags on attachment: 96469 Committed r88392: <http://trac.webkit.org/changeset/88392>

WebKit Review Bot

Comment 41 2011-06-08 14:54:01 PDT

All reviewed patches have been landed. Closing bug.

Noam Rosenthal

Comment 42 2011-06-08 18:06:58 PDT

Created attachment 96522 [details] Last patch: KeyframeValueList coder

Noam Rosenthal

Comment 43 2011-06-08 18:19:57 PDT

Opening for last patch.

Simon Hausmann

Comment 44 2011-10-25 05:54:55 PDT

Comment on attachment 96522 [details] Last patch: KeyframeValueList coder r=me

Igor Trindade Oliveira

Comment 45 2011-11-18 10:46:54 PST

Committed r100789: http://trac.webkit.org/changeset/100789 (In reply to comment #44) > (From update of attachment 96522 [details]) > r=me

Noam Rosenthal

Comment 46 2011-12-06 17:03:02 PST

Comment on attachment 96522 [details] Last patch: KeyframeValueList coder Committed.

Noam Rosenthal

Comment 47 2011-12-06 17:03:21 PST

All patches have landed

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Enhancement

Classification Unclassified

Version 528+ (Nightly build)

Hardware All

OS All

Product WebKit

Component WebKit wx

Assignee

Noam Rosenthal

Reported

2011-05-28 15:00 PDT

Modified

2011-12-06 17:03 PST History

CC List

9 users Show

URL

Keywords

Depends on

62192

Blocks

56935

Dependencies

tree graph