WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
61390
Add IntPoint versions of IntRect::move and IntPoint::move
https://bugs.webkit.org/show_bug.cgi?id=61390
Summary
Add IntPoint versions of IntRect::move and IntPoint::move
Emil A Eklund
Reported
2011-05-24 13:32:18 PDT
From
bug 60806
> It's a bit strange, but perhaps we should consider a flavor of IntRect::move that takes a point?
Attachments
Patch
(24.28 KB, patch)
2011-05-24 14:30 PDT
,
Levi Weintraub
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Levi Weintraub
Comment 1
2011-05-24 13:35:59 PDT
Thanks! I was in the middle of filing this. I'm partly through implementing it and changing a bunch of existing call sites :)
Levi Weintraub
Comment 2
2011-05-24 14:30:38 PDT
Created
attachment 94688
[details]
Patch
Eric Seidel (no email)
Comment 3
2011-05-24 19:10:00 PDT
Comment on
attachment 94688
[details]
Patch Seems OK to me, but others may have concerns about the IntSize vs. IntPoint purity.
Levi Weintraub
Comment 4
2011-05-25 10:06:36 PDT
Comment on
attachment 94688
[details]
Patch Clearing flags on attachment: 94688 Committed
r87303
: <
http://trac.webkit.org/changeset/87303
>
Levi Weintraub
Comment 5
2011-05-25 10:06:41 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug