WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
61044
[Qt] Fix tst_QGraphicsWebView::setPalette(inactiveBG) autotest
https://bugs.webkit.org/show_bug.cgi?id=61044
Summary
[Qt] Fix tst_QGraphicsWebView::setPalette(inactiveBG) autotest
Csaba Osztrogonác
Reported
2011-05-18 05:12:11 PDT
Error message with
r86748
: FAIL! : tst_QGraphicsWebView::setPalette(inactiveBG) Compared pointers are not the same Actual (QApplication::activeWindow()): (nil) Expected (activeView): 0xfffeddd8 Loc: [/ramdisk/qt-linux-release/build/Source/WebKit/qt/tests/qgraphicswebview/tst_qgraphicswebview.cpp(450)]
Attachments
Patch
(1.84 KB, patch)
2011-05-26 10:18 PDT
,
Alexis Menard (darktears)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alexis Menard (darktears)
Comment 1
2011-05-26 09:10:01 PDT
Ossy got some news? Is that a flacky test?
Csaba Osztrogonác
Comment 2
2011-05-26 09:18:22 PDT
Yes, it is. Feel free to check the results on the bot and pick up this bug.
Alexis Menard (darktears)
Comment 3
2011-05-26 10:18:27 PDT
Created
attachment 95000
[details]
Patch
Alexis Menard (darktears)
Comment 4
2011-05-26 10:19:57 PDT
(In reply to
comment #3
)
> Created an attachment (id=95000) [details] > Patch
Sounds like more a workaround but if it works. It's a regression on the new bots it seems all of that was working before. Ossy can you test?
Csaba Osztrogonác
Comment 5
2011-05-27 07:30:29 PDT
Comment on
attachment 95000
[details]
Patch Unfortunately I can't reproduce this bug locally now, but it still fails on the buildbot intermittently. I hope this patch will fix this flakiness. :) So r=me.
WebKit Commit Bot
Comment 6
2011-05-27 08:34:29 PDT
Comment on
attachment 95000
[details]
Patch Clearing flags on attachment: 95000 Committed
r87514
: <
http://trac.webkit.org/changeset/87514
>
WebKit Commit Bot
Comment 7
2011-05-27 08:34:35 PDT
All reviewed patches have been landed. Closing bug.
Ademar Reis
Comment 8
2011-05-27 11:23:07 PDT
Revision
r87514
cherry-picked into qtwebkit-2.2 with commit 329d0c6 <
http://gitorious.org/webkit/qtwebkit/commit/329d0c6
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug