RESOLVED FIXED 61003
Change RenderTextControl::hitInnerTextElement to use IntPoint 
https://bugs.webkit.org/show_bug.cgi?id=61003
Summary Change RenderTextControl::hitInnerTextElement to use IntPoint
Emil A Eklund
Reported 2011-05-17 16:25:06 PDT
Change RenderTextControl::hitInnerTextElement to use IntPoint
Attachments
Patch (4.10 KB, patch)
2011-05-17 16:27 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.05 KB, patch)
2011-05-18 14:51 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Emil A Eklund
Comment 1 2011-05-17 16:27:25 PDT
Created attachment 93843 [details] Patch
Darin Adler
Comment 2 2011-05-17 18:18:34 PDT
Comment on attachment 93843 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=93843&action=review > Source/WebCore/rendering/RenderTextControl.cpp:473 > + result.setLocalPoint(pointInContainer - IntSize(tx + x() + m_innerText->renderBox()->x(), > + ty + y() + m_innerText->renderBox()->y())); We shouldn’t line up like this. The style guide specifically says not to.
Emil A Eklund
Comment 3 2011-05-17 18:28:18 PDT
> We shouldn’t line up like this. The style guide specifically says not to. Will fix before I commit, thanks for pointing it out!
Emil A Eklund
Comment 4 2011-05-18 14:51:46 PDT
Created attachment 93987 [details] Patch for landing
WebKit Commit Bot
Comment 5 2011-05-18 17:14:29 PDT
The commit-queue encountered the following flaky tests while processing attachment 93987 [details]: http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com) http/tests/websocket/tests/multiple-connections.html bug 53825 (author: abarth@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2011-05-18 17:16:55 PDT
Comment on attachment 93987 [details] Patch for landing Clearing flags on attachment: 93987 Committed r86807: <http://trac.webkit.org/changeset/86807>
WebKit Commit Bot
Comment 7 2011-05-18 17:16:59 PDT
All reviewed patches have been landed. Closing bug.
Emil A Eklund
Comment 9 2011-05-19 10:01:20 PDT
Those two tests appears to be flakey, they passed in the most recent build but failed the one before: http://build.webkit.org/builders/Leopard%20Intel%20Debug%20%28Tests%29/builds/30442/steps/layout-test/logs/stdio
Note You need to log in before you can comment on or make changes to this bug.