RESOLVED FIXED 60920
editing/deleting/5091898.html should be renamed and converted to a dump-as-markup test 
https://bugs.webkit.org/show_bug.cgi?id=60920
Summary editing/deleting/5091898.html should be renamed and converted to a dump-as-ma...
Ryosuke Niwa
Reported 2011-05-16 13:50:34 PDT
5091898.html should be a dump-as-markup test and the filename should be changed to something more descriptive.
Attachments
converted the test (13.05 KB, patch)
2011-05-16 13:59 PDT, Ryosuke Niwa 		enrica: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2011-05-16 13:59:30 PDT
Created attachment 93690 [details] converted the test
Enrica Casucci
Comment 2 2011-05-16 14:06:32 PDT
Comment on attachment 93690 [details] converted the test View in context: https://bugs.webkit.org/attachment.cgi?id=93690&action=review I would prefer if you renamed the file instead of removing and adding, simply to preserve the change history. > LayoutTests/editing/deleting/delete-line-break-before-underlined-content.html:6 > <script> Since you're rewriting this, I would add the instructions to run the test manually, just for the sake of clarity.
Ryosuke Niwa
Comment 3 2011-05-16 14:09:07 PDT
Thanks for the review! (In reply to comment #2) > (From update of attachment 93690 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=93690&action=review > > I would prefer if you renamed the file instead of removing and adding, simply to preserve the change history. Yes, I did use svn mv. It's just that pretty-patch doesn't support it. > > LayoutTests/editing/deleting/delete-line-break-before-underlined-content.html:6 > > <script> > > Since you're rewriting this, I would add the instructions to run the test manually, just for the sake of clarity. Will do!
Ryosuke Niwa
Comment 4 2011-05-16 14:17:16 PDT
Committed r86605: <http://trac.webkit.org/changeset/86605>
Ademar Reis
Comment 5 2011-05-23 14:07:50 PDT
Revision r86605 cherry-picked into qtwebkit-2.2 with commit b3dc19e <http://gitorious.org/webkit/qtwebkit/commit/b3dc19e>
Ademar Reis
Comment 6 2011-05-26 15:40:11 PDT
Revision r86605 cherry-picked into qtwebkit-2.2 with commit 40d8b0f <http://gitorious.org/webkit/qtwebkit/commit/40d8b0f>
Note You need to log in before you can comment on or make changes to this bug.