WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
60312
Huge monster change for <track>
https://bugs.webkit.org/show_bug.cgi?id=60312
Summary
Huge monster change for <track>
Anna Cavender
Reported
2011-05-05 16:35:41 PDT
This bug is intended to be a home for a monster <track> change which will NEVER be up for review and NEVER be committed. To be used for reference for reviewers reviewing smaller patches in case they need some context.
Attachments
Patch
(173.20 KB, patch)
2011-05-05 16:45 PDT
,
Anna Cavender
annacc
: review-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anna Cavender
Comment 1
2011-05-05 16:45:11 PDT
Created
attachment 92496
[details]
Patch
WebKit Review Bot
Comment 2
2011-05-05 16:50:25 PDT
Attachment 92496
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Last 3072 characters of output: oved when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Source/WebCore/html/TextTrack.cpp:112: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/html/TextTrack.cpp:113: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/bindings/v8/custom/V8TextTrackCueCustom.cpp:51: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebCore/html/HTMLTrackElement.h:80: Should have a space between // and comment [whitespace/comments] [4] Source/WebCore/html/HTMLMediaElement.cpp:755: One line control clauses should not use braces. [whitespace/braces] [4] Source/WebCore/html/HTMLMediaElement.cpp:760: One line control clauses should not use braces. [whitespace/braces] [4] Source/WebCore/html/HTMLMediaElement.cpp:1684: Should have a space between // and comment [whitespace/comments] [4] Source/WebCore/html/HTMLMediaElement.cpp:1690: Missing space before ( in if( [whitespace/parens] [5] Source/WebCore/html/HTMLMediaElement.cpp:1690: More than one command on the same line in if [whitespace/parens] [4] Source/WebCore/html/HTMLMediaElement.cpp:1982: Local variables should never be PassRefPtr (see
http://webkit.org/coding/RefPtr.html
). [readability/pass_ptr] [5] Source/WebCore/html/HTMLMediaElement.cpp:1996: More than one command on the same line in if [whitespace/parens] [4] Source/WebCore/html/HTMLMediaElement.cpp:2026: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebCore/html/MutableTextTrackImpl.cpp:81: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WebCore/html/MutableTextTrackImpl.cpp:85: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WebCore/bindings/js/JSTextTrackCueCustom.cpp:33: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/bindings/js/JSTextTrackCueCustom.cpp:54: One line control clauses should not use braces. [whitespace/braces] [4] Source/WebCore/platform/track/WebVTTParser.cpp:35: You should add a blank line after implementation file's own header. [build/include_order] [4] Source/WebCore/platform/track/WebVTTParser.cpp:48: current_line is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebCore/platform/track/WebVTTParser.cpp:57: One line control clauses should not use braces. [whitespace/braces] [4] Source/WebCore/platform/track/WebVTTParser.cpp:78: One line control clauses should not use braces. [whitespace/braces] [4] Source/WebCore/html/CueIndex.cpp:126: This { should be at the end of the previous line [whitespace/braces] [4] Source/WebCore/html/CueIndex.cpp:141: Missing space before ( in if( [whitespace/parens] [5] Source/WebCore/html/CueIndex.cpp:141: More than one command on the same line in if [whitespace/parens] [4] Total errors found: 56 in 74 files If any of these errors are false positives, please file a bug against check-webkit-style.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug