RESOLVED WONTFIX 59893
[android] Provide build-webkit integration for the CMake buildsystem 
https://bugs.webkit.org/show_bug.cgi?id=59893
Summary [android] Provide build-webkit integration for the CMake buildsystem
Holger Freyther
Reported 2011-05-01 14:20:44 PDT
[android] Provide build-webkit integration for the CMake buildsystem
Attachments
Patch (5.71 KB, patch)
2011-05-01 14:27 PDT, Holger Freyther 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Holger Freyther
Comment 1 2011-05-01 14:27:15 PDT
Created attachment 91846 [details] Patch
Adam Barth
Comment 2 2011-05-11 21:03:56 PDT
Comment on attachment 91846 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91846&action=review > Tools/Scripts/build-webkit:569 > + buildCMakeProjectOrExit($clean, "Android", $prefixPath, $makeArgs, cMakeArgsFromFeatures()); Is CMake able to build the Android port?
Adam Barth
Comment 3 2011-05-11 21:04:14 PDT
+steveblock
Steve Block
Comment 4 2011-05-12 02:25:59 PDT
Comment on attachment 91846 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91846&action=review >> Tools/Scripts/build-webkit:569 >> + buildCMakeProjectOrExit($clean, "Android", $prefixPath, $makeArgs, cMakeArgsFromFeatures()); > > Is CMake able to build the Android port? See my comment in https://bugs.webkit.org/show_bug.cgi?id=59892#c6
Eric Seidel (no email)
Comment 5 2011-06-02 07:55:12 PDT
Steve, can you please r+ or r- this?
Steve Block
Comment 6 2011-08-23 05:25:40 PDT
Comment on attachment 91846 [details] Patch As I mentioned before, the Android port was never fully upstreamed, so won't build without major changes. Also, the existing incomplete port is now being removed, see Bug 66688. I'm not familiar with CMake, but it looks to me like this patch simply does some set-up for buildwebkit --android. I guess there's nothing wrong with it, but I'm hesitant to r+ because I don't know the plans for CMake.
Adam Barth
Comment 7 2011-09-05 11:51:55 PDT
Comment on attachment 91846 [details] Patch Android now uses GYP.
Note You need to log in before you can comment on or make changes to this bug.