RESOLVED FIXED 59008
[buildbot]Show more recent builds on builder page 
https://bugs.webkit.org/show_bug.cgi?id=59008
Summary [buildbot]Show more recent builds on builder page
Csaba Osztrogonác
Reported Wednesday, April 20, 2011 6:44:24 PM UTC
If I click on a builder on waterfall page, I can see only 5 builds under the recent builds. It would be great if we can see more than 5 to make gardening more effective. I know that I can add "?numbuilds=100" to the URL, but it isn't so user friendly. Can't we add this option to master.cfg somehow?
Attachments
template patch (3.59 KB, patch)
2011-04-20 11:01 PDT, Peter Gal 		ossy: review-
ossy: commit-queue-
DetailsFormatted DiffDiff
base template (3.38 KB, patch)
2011-04-20 11:57 PDT, Peter Gal 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Peter Gal
Comment 1 Wednesday, April 20, 2011 6:57:31 PM UTC
(In reply to comment #0) > If I click on a builder on waterfall page, > I can see only 5 builds under the recent builds. > > It would be great if we can see more than 5 to make gardening more effective. > I know that I can add "?numbuilds=100" to the URL, but it isn't so user friendly. > Can't we add this option to master.cfg somehow? It is possible to pass 'numbuilds' argument to the WebStatus in the master.cfg, but that does not affects the builder's page. But we can override the build in template which will contain the required extra links.
Peter Gal
Comment 2 Wednesday, April 20, 2011 7:01:03 PM UTC
Created attachment 90362 [details] template patch Simply added these lines to the built-in template: ( Show: <a href="{{ builder_url }}">default</a> {% for count in [25, 50, 100, 200] %} <a href="{{ builder_url }}?numbuilds={{ count }}">{{ count }}</a> {% endfor %}) This will show five links with different 'numbuilds' parameters.
Csaba Osztrogonác
Comment 3 Wednesday, April 20, 2011 7:03:43 PM UTC
Comment on attachment 90362 [details] template patch yay, shibbbyyyy! r=me
Csaba Osztrogonác
Comment 4 Wednesday, April 20, 2011 7:05:08 PM UTC
Adam, could you run a reconfigure on the buildmaster after it is landed?
Peter Gal
Comment 5 Wednesday, April 20, 2011 7:05:53 PM UTC
BTW, this template is from Buildbot v0.8.3, so it should apply cleanly to the apple's buildmaster.
Adam Roben (:aroben)
Comment 6 Wednesday, April 20, 2011 7:28:44 PM UTC
It would be slightly clearer to check in the unmodified template first, and then customize it after that in a separate change. I can take care of updating the master after this lands.
Csaba Osztrogonác
Comment 7 Wednesday, April 20, 2011 7:32:19 PM UTC
Comment on attachment 90362 [details] template patch OK, let's check in the unmodified template first, and then patch it.
Peter Gal
Comment 8 Wednesday, April 20, 2011 7:57:22 PM UTC
Created attachment 90375 [details] base template This is the built-in template from buildbot v0.8.3.
WebKit Commit Bot
Comment 9 Wednesday, April 20, 2011 9:17:52 PM UTC
The commit-queue encountered the following flaky tests while processing attachment 90362 [details]: http/tests/xmlhttprequest/logout.html bug 52047 (author: ap@webkit.org) The commit-queue is continuing to process your patch.
Csaba Osztrogonác
Comment 10 Wednesday, April 20, 2011 10:50:16 PM UTC
Comment on attachment 90375 [details] base template Landed in http://trac.webkit.org/changeset/84421
Csaba Osztrogonác
Comment 11 Wednesday, April 20, 2011 10:58:47 PM UTC
Modifying the default template landed in http://trac.webkit.org/changeset/84423
WebKit Review Bot
Comment 12 Wednesday, April 20, 2011 11:05:20 PM UTC
http://trac.webkit.org/changeset/84423 might have broken Chromium Win Release
Peter Gal
Comment 13 Thursday, April 21, 2011 10:20:21 AM UTC
(In reply to comment #11) > Modifying the default template landed in http://trac.webkit.org/changeset/84423 Cool, Thanks!
Note You need to log in before you can comment on or make changes to this bug.