RESOLVED FIXED 57419
Move factory-like things in EventDispatcher::dispatchMouseEvent to a factory, clean up names and ordering. 
https://bugs.webkit.org/show_bug.cgi?id=57419
Summary Move factory-like things in EventDispatcher::dispatchMouseEvent to a factory,...
Dimitri Glazkov (Google)
Reported 2011-03-29 21:33:46 PDT
Move factory-like things in EventDispatcher::dispatchMouseEvent to a factory, clean up names and ordering.
Attachments
Patch (7.04 KB, patch)
2011-03-29 21:35 PDT, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Rebased against ToT. (6.89 KB, patch)
2011-03-30 09:03 PDT, Dimitri Glazkov (Google) 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2011-03-29 21:35:22 PDT
Created attachment 87463 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2011-03-30 09:03:22 PDT
Created attachment 87545 [details] Rebased against ToT.
Darin Adler
Comment 3 2011-03-30 10:43:33 PDT
Comment on attachment 87545 [details] Rebased against ToT. View in context: https://bugs.webkit.org/attachment.cgi?id=87545&action=review > Source/WebCore/dom/MouseEvent.cpp:33 > +PassRefPtr<MouseEvent> MouseEvent::create(const AtomicString& eventType, PassRefPtr<AbstractView> view, const PlatformMouseEvent& event, const IntPoint& position, int detail, PassRefPtr<Node> relatedTargetArg) No need for arg in relatedTargetArg. > Source/WebCore/dom/MouseEvent.cpp:35 > + bool cancelable = eventType != eventNames().mousemoveEvent; Change this to isCancelable instead of cancelable please. > Source/WebCore/dom/MouseEvent.cpp:38 > + return MouseEvent::create(eventType, > + true, cancelable, view, Nitpickiest of nitpicks: I’d merge these two into one line. > Source/WebCore/dom/MouseEvent.cpp:41 > + relatedTargetArg, 0, false); Extra space here. > Source/WebCore/dom/MouseEvent.h:49 > + static PassRefPtr<MouseEvent> create(const AtomicString& eventType, PassRefPtr<AbstractView>, const PlatformMouseEvent&, const IntPoint&, int detail, PassRefPtr<Node> relatedTargetArg); No need for arg in relatedTargetArg.
Dimitri Glazkov (Google)
Comment 4 2011-03-30 14:43:09 PDT
Thanks for review, Darin. Will fix and land.
Dimitri Glazkov (Google)
Comment 5 2011-03-30 14:44:34 PDT
Committed r82501: <http://trac.webkit.org/changeset/82501>
Note You need to log in before you can comment on or make changes to this bug.