RESOLVED FIXED 56864
Add the remaining steps to WebCore GYP build 
https://bugs.webkit.org/show_bug.cgi?id=56864
Summary Add the remaining steps to WebCore GYP build
Adam Barth
Reported 2011-03-22 14:41:09 PDT
Add the remaining steps to WebCore GYP build
Attachments
Patch (5.07 KB, patch)
2011-03-22 14:44 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-03-22 14:44:39 PDT
Created attachment 86510 [details] Patch
Eric Seidel (no email)
Comment 2 2011-03-22 14:47:47 PDT
Comment on attachment 86510 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86510&action=review > Source/WebCore/gyp/copy-inspector-resources.sh:8 > +rm -f "${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/inspector/WebKit.qrc" Seems ${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/inspector wants to be a local variable. :)
Adam Barth
Comment 3 2011-03-22 14:48:56 PDT
(In reply to comment #2) > (From update of attachment 86510 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=86510&action=review > > > Source/WebCore/gyp/copy-inspector-resources.sh:8 > > +rm -f "${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/inspector/WebKit.qrc" > > Seems ${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/inspector wants to be a local variable. :) True. I didn't write this script. (It's hard-coded into the xcodeproj.) I suspect once we have this stuff "out in the open", there are lots of things we can improve.
Adam Barth
Comment 4 2011-03-22 14:52:14 PDT
Comment on attachment 86510 [details] Patch Clearing flags on attachment: 86510 Committed r81706: <http://trac.webkit.org/changeset/81706>
Adam Barth
Comment 5 2011-03-22 14:52:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.