Created attachment 86504 [details] Patch

If there is a difference between Release and Profiling (other than name) and I failed to correctly replicate that difference in the gyp build, please let me know and I'll be happy to fix it!

Committed r81701: <http://trac.webkit.org/changeset/81701>

I see support for --profiling in build-webkit (via webkitdirs.pm): if ($opt =~ /^--profil(e|ing)$/i) { splice(@ARGV, $i, 1); $passedConfiguration = "Profiling"; $passedConfiguration .= "_Cairo_CFLite" if ($isWinCairo && isCygwin()); return; } But no other references in the project as far as I can tell.

This was added as part of the SFX write. I suspect it is now vestigial: http://trac.webkit.org/changeset/36244

It’s not. The differences are in the .xcconfig files.

Yes, "Profiling" was added by mrowe back in: http://trac.webkit.org/changeset/36136 and was different from Release at that time. I no longer believe it's different since we no longer explicitly set -fomit-frame-pointer in any configuration that I can tell. (at least not via the pbxproj file).

(In reply to comment #6) > It’s not. The differences are in the .xcconfig files. I'll just trust you on that one. :) I don't see them, but that doesn't mean they're not there. Can you confirm that I set up Profiling correctly in the GYP build? I've verified that the generated project.pbxproj looks the same (at least as far as this is concerned).

(In reply to comment #7) > Yes, "Profiling" was added by mrowe back in: > http://trac.webkit.org/changeset/36136 > and was different from Release at that time. > I no longer believe it's different since we no longer explicitly set -fomit-frame-pointer in any configuration that I can tell. (at least not via the pbxproj file). OTHER_CFLAGS = $(OTHER_CFLAGS_$(CONFIGURATION)_$(CURRENT_VARIANT)); OTHER_CFLAGS_Release_normal = $(OTHER_CFLAGS_normal_$(TARGET_GCC_VERSION)); OTHER_CFLAGS_Production_normal = $(OTHER_CFLAGS_normal_$(TARGET_GCC_VERSION)); OTHER_CFLAGS_normal_GCC_42 = -fomit-frame-pointer -funwind-tables; OTHER_CFLAGS_normal_LLVM_GCC_42 = $(OTHER_CFLAGS_normal_GCC_42); “grep” clearly shows that we DO set -fomit-frame-pointer.

(In reply to comment #9) > (In reply to comment #7) > > Yes, "Profiling" was added by mrowe back in: > > http://trac.webkit.org/changeset/36136 > > and was different from Release at that time. > > I no longer believe it's different since we no longer explicitly set -fomit-frame-pointer in any configuration that I can tell. (at least not via the pbxproj file). > > OTHER_CFLAGS = $(OTHER_CFLAGS_$(CONFIGURATION)_$(CURRENT_VARIANT)); > OTHER_CFLAGS_Release_normal = $(OTHER_CFLAGS_normal_$(TARGET_GCC_VERSION)); > OTHER_CFLAGS_Production_normal = $(OTHER_CFLAGS_normal_$(TARGET_GCC_VERSION)); > OTHER_CFLAGS_normal_GCC_42 = -fomit-frame-pointer -funwind-tables; > OTHER_CFLAGS_normal_LLVM_GCC_42 = $(OTHER_CFLAGS_normal_GCC_42); > > “grep” clearly shows that we DO set -fomit-frame-pointer. Interesting. Thank you for the information.