RESOLVED FIXED 56788
GYP build should not have include paths that point within the source tree 
https://bugs.webkit.org/show_bug.cgi?id=56788
Summary GYP build should not have include paths that point within the source tree
Adam Barth
Reported 2011-03-21 17:29:59 PDT
Sayth Mark: [[ The generated Xcode project explicitly adds header include paths that point within the source tree. ]] I think I fixed this problem for the WebCore build, but I need to go back to the JavaScriptCore build and fix this issue.
Attachments
Patch (3.67 KB, patch)
2011-03-21 18:01 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-03-21 18:01:35 PDT
Created attachment 86398 [details] Patch
Eric Seidel (no email)
Comment 2 2011-03-21 18:03:47 PDT
Comment on attachment 86398 [details] Patch What about for every non-mac port? it seems removing these is premature.
Adam Barth
Comment 3 2011-03-21 18:15:28 PDT
> What about for every non-mac port? it seems removing these is premature. I'd say that adding them is premature. :) We'll solve the non-mac port problem when we get there.
Eric Seidel (no email)
Comment 4 2011-03-21 18:18:09 PDT
Comment on attachment 86398 [details] Patch I guess. I'm pretty certain you'll want to revert this change the moment you try and build anywhere else, but your reasoning is fair.
WebKit Commit Bot
Comment 5 2011-03-21 22:40:08 PDT
Comment on attachment 86398 [details] Patch Clearing flags on attachment: 86398 Committed r81647: <http://trac.webkit.org/changeset/81647>
WebKit Commit Bot
Comment 6 2011-03-21 22:40:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.