RESOLVED FIXED 56666
Media Stream API: adding Stream and GeneratedStream classes. 
https://bugs.webkit.org/show_bug.cgi?id=56666
Summary Media Stream API: adding Stream and GeneratedStream classes.
Leandro Graciá Gil
Reported 2011-03-18 12:09:29 PDT
This patch introduces the Stream and GeneratedStream classes according to the lastest specification and integrating to the code introduced by previous patches.
Attachments
Patch (64.11 KB, patch)
2011-03-18 12:42 PDT, Leandro Graciá Gil 		no flags
DetailsFormatted DiffDiff
Patch (114.04 KB, patch)
2011-03-18 12:57 PDT, Leandro Graciá Gil 		no flags
DetailsFormatted DiffDiff
Patch (63.87 KB, patch)
2011-05-17 11:36 PDT, Leandro Graciá Gil 		no flags
DetailsFormatted DiffDiff
Patch (64.94 KB, patch)
2011-05-20 11:13 PDT, Leandro Graciá Gil 		no flags
DetailsFormatted DiffDiff
Patch (64.83 KB, patch)
2011-05-23 11:18 PDT, Leandro Graciá Gil 		no flags
DetailsFormatted DiffDiff
Patch (64.87 KB, patch)
2011-05-24 06:12 PDT, Leandro Graciá Gil 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Leandro Graciá Gil
Comment 1 2011-03-18 12:42:08 PDT
Created attachment 86196 [details] Patch
Leandro Graciá Gil
Comment 2 2011-03-18 12:57:06 PDT
Created attachment 86200 [details] Patch
Leandro Graciá Gil
Comment 3 2011-03-18 12:57:24 PDT
No contents changed. Rebasing to solve problems with the bots.
Leandro Graciá Gil
Comment 4 2011-03-23 13:20:42 PDT
Updating the bug platform settings (had the default ones).
Leandro Graciá Gil
Comment 5 2011-05-17 11:36:01 PDT
Created attachment 93803 [details] Patch
Leandro Graciá Gil
Comment 6 2011-05-20 11:13:39 PDT
Created attachment 94243 [details] Patch Some minor fixes.
Tony Gentilcore
Comment 7 2011-05-23 06:06:46 PDT
Comment on attachment 94243 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=94243&action=review Just a couple of small questions. Everything else lgtm. > Source/WebCore/dom/GeneratedStream.cpp:82 > + if (m_readyState != ENDED) Since stop() needs to be robust to ENDED streams, perhaps it would be easier to just call stop() unconditionally here at let it fail the first check? > Source/WebCore/dom/Stream.cpp:57 > + if (m_readyState == ENDED) I might be missing it, but it doesn't seem like we'd ever want to call streamEnded while m_readyState == ENDED. If not, should we ASSERT here instead? > Source/WebCore/dom/Stream.idl:36 > + attribute EventListener onreadystatechange; onreadystatechange isn't in: http://www.whatwg.org/specs/web-apps/current-work/#stream Should we have it?
Tommy Widenflycht
Comment 8 2011-05-23 06:53:01 PDT
Looks good to me, modulo Tony's comments. View in context: https://bugs.webkit.org/attachment.cgi?id=94243&action=review >> Source/WebCore/dom/Stream.idl:36 >> + attribute EventListener onreadystatechange; > > onreadystatechange isn't in: > http://www.whatwg.org/specs/web-apps/current-work/#stream > > Should we have it? Right, it used to be in the spec but must have been recently removed.
Leandro Graciá Gil
Comment 9 2011-05-23 11:18:15 PDT
Created attachment 94448 [details] Patch
Leandro Graciá Gil
Comment 10 2011-05-23 11:21:32 PDT
Comment on attachment 94243 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=94243&action=review >> Source/WebCore/dom/GeneratedStream.cpp:82 >> + if (m_readyState != ENDED) > > Since stop() needs to be robust to ENDED streams, perhaps it would be easier to just call stop() unconditionally here at let it fail the first check? Fixed. >> Source/WebCore/dom/Stream.cpp:57 >> + if (m_readyState == ENDED) > > I might be missing it, but it doesn't seem like we'd ever want to call streamEnded while m_readyState == ENDED. If not, should we ASSERT here instead? Fixed. >> Source/WebCore/dom/Stream.idl:36 >> + attribute EventListener onreadystatechange; > > onreadystatechange isn't in: > http://www.whatwg.org/specs/web-apps/current-work/#stream > > Should we have it? Fixed.
WebKit Commit Bot
Comment 11 2011-05-24 06:00:46 PDT
Comment on attachment 94448 [details] Patch Rejecting attachment 94448 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'apply-..." exit_code: 2 Last 500 characters of output: e/WebCore/page/MediaStreamController.h patching file Source/WebCore/page/MediaStreamFrameController.cpp patching file Source/WebCore/page/MediaStreamFrameController.h patching file Source/WebCore/page/NavigatorUserMediaError.h patching file Source/WebCore/page/NavigatorUserMediaSuccessCallback.h patching file Source/WebCore/page/NavigatorUserMediaSuccessCallback.idl Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Tony Gentilcore', u'--..." exit_code: 1 Full output: http://queues.webkit.org/results/8734083
Leandro Graciá Gil
Comment 12 2011-05-24 06:12:18 PDT
Created attachment 94598 [details] Patch Rebase only.
WebKit Commit Bot
Comment 13 2011-05-24 08:12:03 PDT
Comment on attachment 94598 [details] Patch Clearing flags on attachment: 94598 Committed r87150: <http://trac.webkit.org/changeset/87150>
WebKit Commit Bot
Comment 14 2011-05-24 08:12:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.