RESOLVED FIXED 56498
Move volume slider positioning logic to a custom renderer. 
https://bugs.webkit.org/show_bug.cgi?id=56498
Summary Move volume slider positioning logic to a custom renderer.
Dimitri Glazkov (Google)
Reported 2011-03-16 16:11:18 PDT
Move volume slider positioning logic to a custom renderer.
Attachments
Patch (6.17 KB, patch)
2011-03-16 16:12 PDT, Dimitri Glazkov (Google) 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2011-03-16 16:12:55 PDT
Created attachment 85993 [details] Patch
Eric Seidel (no email)
Comment 2 2011-03-17 04:16:16 PDT
Comment on attachment 85993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=85993&action=review Seems reasonable. What's the motivation here? > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) You'll need to remove that.
Dimitri Glazkov (Google)
Comment 3 2011-03-17 08:24:05 PDT
(In reply to comment #2) > (From update of attachment 85993 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=85993&action=review > > Seems reasonable. What's the motivation here? Ah good question. I need to put a desc in ChangeLog. By moving the logic to a renderer, we are eliminating the need to fiddle with RenderStyle from DOM, which is what the original code was doing. If this were possible to accomplish with CSS, that would've been the proper route to follow. Since the behavior (stay on top of a sibling) can't be described in terms of CSS, the custom renderer is the way to go. > > > Source/WebCore/ChangeLog:8 > > + No new tests. (OOPS!) > > You'll need to remove that. OOPS indeed :)
Dimitri Glazkov (Google)
Comment 4 2011-03-22 09:16:49 PDT
Committed r81671: <http://trac.webkit.org/changeset/81671>
WebKit Review Bot
Comment 5 2011-03-22 11:39:48 PDT
http://trac.webkit.org/changeset/81671 might have broken GTK Linux 32-bit Debug The following tests are not passing: inspector/debugger/debug-inlined-scripts.html
Note You need to log in before you can comment on or make changes to this bug.