NEW 55904
selectionHasStyle should call selectionStartHasStyle when shouldToggleStyleBasedOnStartOfSelection 
https://bugs.webkit.org/show_bug.cgi?id=55904
Summary selectionHasStyle should call selectionStartHasStyle when shouldToggleStyleBa...
Ryosuke Niwa
Reported 2011-03-07 13:45:06 PST
Currently, EditorCommand is responsible for checking the value returned by shouldToggleStyleBasedOnStartOfSelection and calling either selectionHasStyle or selectionStartHasStyle. However, each port also calls selectionHasStyle in Source/WebKit without calling shouldToggleStyleBasedOnStartOfSelection and causing Mac port to behave inconsistently. We should merge these two functions so that selectionHasStyle calls selectionStartHasStyle as needed.
Attachments
Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2011-03-07 22:46:51 PST
Mn... this bug might be invalid after all. We do call selectionHasStyle in WebKit but only for text direction. And it seems odd to determine the direction of text merely based at the selection start.
Note You need to log in before you can comment on or make changes to this bug.