WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
55207
Move HTMLEquivalent and its subclasses to EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=55207
Summary
Move HTMLEquivalent and its subclasses to EditingStyle
Ryosuke Niwa
Reported
2011-02-25 00:06:03 PST
Right now, ApplyStyleCommand is responsible for both determining which style, elements, attributes to be removed and to be added. In the long run, we'd like to move this responsibility over to EditingStyle. This is bug is about moving HTMLEquivalent and its subclasses along with the logic to determine which elements and attributes are moved from ApplyStyleCommand to EditingStyle. While this introduces a slight overhad, it simplifies the code in ApplyStyleCommand significantly and helps to separate the responsibilities of ApplyStyleCommand and EditingStyle so it should be a win in the long term.
Attachments
cleanup
(30.73 KB, patch)
2011-02-25 00:20 PST
,
Ryosuke Niwa
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2011-02-25 00:20:34 PST
Created
attachment 83779
[details]
cleanup
Ryosuke Niwa
Comment 2
2011-02-25 21:26:46 PST
Committed
r79758
: <
http://trac.webkit.org/changeset/79758
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug