RESOLVED FIXED 54853
Move TextControlInnerElements from WebCore/rendering to WebCore/html/shadow 
https://bugs.webkit.org/show_bug.cgi?id=54853
Summary Move TextControlInnerElements from WebCore/rendering to WebCore/html/shadow
Roland Steiner
Reported 2011-02-20 23:00:36 PST
Move the source files TextControlInnerElements.cpp/.h containing shadow DOM code for <input> elements from WebCore/rendering to WebCore/html/shadow as a first step in the larger refactoring of moving <input> to use the new shadow DOM approach. (cf. https://bugs.webkit.org/show_bug.cgi?id=54179 et al)
Attachments
Patch (21.29 KB, patch)
2011-02-20 23:11 PST, Roland Steiner 		no flags
DetailsFormatted DiffDiff
patch - including moved files (70.28 KB, patch)
2011-02-20 23:14 PST, Roland Steiner 		no flags
DetailsFormatted DiffDiff
patch, from SVN checkout (70.20 KB, patch)
2011-02-21 22:41 PST, Roland Steiner 		no flags
DetailsFormatted DiffDiff
patch, SVN, fixes (69.27 KB, patch)
2011-02-22 01:33 PST, Roland Steiner 		tkent: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Roland Steiner
Comment 1 2011-02-20 23:11:37 PST
Created attachment 83132 [details] Patch
Roland Steiner
Comment 2 2011-02-20 23:14:10 PST
Created attachment 83133 [details] patch - including moved files Iiiinteresting - webkit-patch seems to have troubles with renamed/moved files. Uploading the full patch manually.
WebKit Review Bot
Comment 3 2011-02-20 23:15:48 PST
Attachment 83132 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7939695
Early Warning System Bot
Comment 4 2011-02-20 23:23:55 PST
Attachment 83132 [details] did not build on qt: Build output: http://queues.webkit.org/results/7940593
Kent Tamura
Comment 5 2011-02-21 00:08:24 PST
Comment on attachment 83133 [details] patch - including moved files View in context: https://bugs.webkit.org/attachment.cgi?id=83133&action=review The patch will lose svn revision history. Please make a patch in svn checkout. > Source/WebCore/WebCore.xcodeproj/project.pbxproj:22479 > + 14C0BC651312432C0030E8AB /* TextControlInnerElements.h in Headers */, The file list should be sorted. It's ok to run sort-Xcode-project-file after you commit this patch. > Source/WebCore/WebCore.xcodeproj/project.pbxproj:25168 > + 14C0BC641312432C0030E8AB /* TextControlInnerElements.cpp in Sources */, ditto.
Roland Steiner
Comment 6 2011-02-21 00:53:48 PST
Note: Except for moving I left the file and class names as-is, in order to minimize changes. However, I wonder if 'InputInnerElements' (or some such) wouldn't be a nice'n'shorter name.
Roland Steiner
Comment 7 2011-02-21 22:41:55 PST
Created attachment 83274 [details] patch, from SVN checkout
Kent Tamura
Comment 8 2011-02-21 22:53:41 PST
Comment on attachment 83274 [details] patch, from SVN checkout >Index: Source/WebCore/html/shadow/TextControlInnerElements.cpp >=================================================================== >--- Source/WebCore/html/shadow/TextControlInnerElements.cpp (revision 79274) (from Source/WebCore/rendering/TextControlInnerElements.cpp:79274) >+++ Source/WebCore/html/shadow/TextControlInnerElements.cpp (working copy) >@@ -0,0 +1,535 @@ Did you run "svn mv"? The patch seems still wrong. If you operate correctly, this should be a diff from rendering/TextControlInnerElements.cpp to shadow/TextControlInnerElements.cpp.
Build Bot
Comment 9 2011-02-21 23:03:23 PST
Attachment 83274 [details] did not build on win: Build output: http://queues.webkit.org/results/7948033
Kent Tamura
Comment 10 2011-02-22 01:25:38 PST
(In reply to comment #8) > (From update of attachment 83274 [details]) > >Index: Source/WebCore/html/shadow/TextControlInnerElements.cpp > >=================================================================== > >--- Source/WebCore/html/shadow/TextControlInnerElements.cpp (revision 79274) (from Source/WebCore/rendering/TextControlInnerElements.cpp:79274) > >+++ Source/WebCore/html/shadow/TextControlInnerElements.cpp (working copy) > >@@ -0,0 +1,535 @@ > > Did you run "svn mv"? > The patch seems still wrong. If you operate correctly, this should be a diff from rendering/TextControlInnerElements.cpp to shadow/TextControlInnerElements.cpp. I'm sorry, I was wrong. This block contains "(from Source/WebCore/rendering/TextControlInnerElements.cpp)". So it's ok. Anyway, this patch has a problem on WebCore.vcproj.
Roland Steiner
Comment 11 2011-02-22 01:33:23 PST
Created attachment 83284 [details] patch, SVN, fixes Fixed Win. Also removed headers again from WebCore.pro to see if that pacifies the Qt buildbot (but interestingly it didn't seem fazed with the manual patch...)
Kent Tamura
Comment 12 2011-02-22 01:45:38 PST
Comment on attachment 83284 [details] patch, SVN, fixes ok
Roland Steiner
Comment 13 2011-03-01 00:49:11 PST
Committed r79978: <http://trac.webkit.org/changeset/79978>
Ryosuke Niwa
Comment 14 2012-04-21 17:58:04 PDT
Comment on attachment 83284 [details] patch, SVN, fixes Clearing cq?
Note You need to log in before you can comment on or make changes to this bug.