RESOLVED FIXED 54066
[NRWT] Remove encoding parameters in rebaseline. 
https://bugs.webkit.org/show_bug.cgi?id=54066
Summary [NRWT] Remove encoding parameters in rebaseline.
Hayato Ito
Reported 2011-02-08 22:15:09 PST
This is a follow up patch, after this comment, https://bugs.webkit.org/show_bug.cgi?id=53071#c6 We can remove encoding parameters because we can assume all rebaseline data can be written to files in binary mode.
Attachments
remove-encoding-parameters (4.54 KB, patch)
2011-02-08 22:28 PST, Hayato Ito 		tony: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hayato Ito
Comment 1 2011-02-08 22:28:14 PST
Created attachment 81752 [details] remove-encoding-parameters
Tony Chang
Comment 2 2011-02-09 10:43:30 PST
Comment on attachment 81752 [details] remove-encoding-parameters Thanks!
Dirk Pranke
Comment 3 2011-02-09 13:22:46 PST
As long as nothing breaks, I guess this change is fine, but I still feel kind of uncomfortable about it. Perhaps we should also change the expected_text() and expected_checksum() methods in port/base.py to use read_binary_file() instead of read_text_file()?
Tony Chang
Comment 4 2011-02-09 13:42:48 PST
(In reply to comment #3) > As long as nothing breaks, I guess this change is fine, but I still feel kind of uncomfortable about it. Perhaps we should also change the expected_text() and expected_checksum() methods in port/base.py to use read_binary_file() instead of read_text_file()? expected_text() already uses read_binary_file(). expected_checksum() could use either since it's just reading ascii. It's probably a bit safer to use read_text_file(), but I don't feel strongly one way or another.
Dirk Pranke
Comment 5 2011-02-09 13:49:29 PST
(In reply to comment #4) > (In reply to comment #3) > > As long as nothing breaks, I guess this change is fine, but I still feel kind of uncomfortable about it. Perhaps we should also change the expected_text() and expected_checksum() methods in port/base.py to use read_binary_file() instead of read_text_file()? > > expected_text() already uses read_binary_file(). expected_checksum() could use either since it's just reading ascii. It's probably a bit safer to use read_text_file(), but I don't feel strongly one way or another. You're right. Apparently I can't read. Anyway, I would feel better if we changed expected_checksum() to use read_binary_file() as well, for consistency.
Hayato Ito
Comment 6 2011-02-09 21:29:14 PST
Thank you for the reviews. I'll commit the patch after I change expected_checksum() to use read_binary_file(). (In reply to comment #5) > You're right. Apparently I can't read. Anyway, I would feel better if we changed expected_checksum() to use read_binary_file() as well, for consistency.
Hayato Ito
Comment 7 2011-02-09 21:31:48 PST
Committed r78175: <http://trac.webkit.org/changeset/78175>
Note You need to log in before you can comment on or make changes to this bug.