RESOLVED FIXED 52615
Web Inspector: set breakpoints by line:column 
https://bugs.webkit.org/show_bug.cgi?id=52615
Summary Web Inspector: set breakpoints by line:column
Pavel Podivilov
Reported 2011-01-18 01:14:47 PST
Web Inspector: set breakpoints by line:column.
Attachments
Patch. (35.82 KB, patch)
2011-01-18 01:15 PST, Pavel Podivilov 		no flags
DetailsFormatted DiffDiff
Patch. (36.53 KB, patch)
2011-01-18 01:28 PST, Pavel Podivilov 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2011-01-18 01:15:41 PST
Created attachment 79251 [details] Patch.
Pavel Podivilov
Comment 2 2011-01-18 01:28:52 PST
Created attachment 79254 [details] Patch.
Yury Semikhatsky
Comment 3 2011-01-24 04:36:52 PST
Comment on attachment 79254 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=79254&action=review Please address the comments before landing. > Source/WebCore/bindings/js/ScriptDebugServer.cpp:153 > + *actualColumnNumber = 1; Please file a bug against JSC and add FIXME comment here. > Source/WebCore/bindings/js/ScriptDebugServer.h:138 > + typedef HashMap<long, ScriptBreakpoint> ScriptBreakpoints; ScriptBreakpoints -> LineToScriptBreakpointMap > Source/WebCore/bindings/js/ScriptDebugServer.h:139 > + typedef HashMap<intptr_t, ScriptBreakpoints> BreakpointsMap; BreakpointsMap -> SourceIdToBreakpointsMap, I'd also recommend renaming corresponding fields as m_breakpoints sounds too general. > Source/WebCore/inspector/InspectorDebuggerAgent.h:100 > + typedef HashMap<Location, ScriptBreakpoint> ScriptBreakpoints; ScriptBreakpoints -> LocationToBreakpointMap
Pavel Podivilov
Comment 4 2011-01-24 05:56:28 PST
Committed r76509: <http://trac.webkit.org/changeset/76509>
WebKit Review Bot
Comment 5 2011-01-24 06:10:47 PST
http://trac.webkit.org/changeset/76509 might have broken Leopard Intel Release (Build) and Leopard Intel Debug (Build)
Note You need to log in before you can comment on or make changes to this bug.