RESOLVED FIXED 52215
Web Inspector: breakpoint text snippet in breakpoints sidebar pane disappears after reload 
https://bugs.webkit.org/show_bug.cgi?id=52215
Summary Web Inspector: breakpoint text snippet in breakpoints sidebar pane disappears...
Pavel Podivilov
Reported 2011-01-11 08:44:21 PST
Web Inspector: breakpoint text snippet in breakpoints sidebar pane disappears after reload
Attachments
Patch. (6.92 KB, patch)
2011-01-11 08:45 PST, Pavel Podivilov 		no flags
DetailsFormatted DiffDiff
Comments addressed. (8.28 KB, patch)
2011-01-14 05:00 PST, Pavel Podivilov 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2011-01-11 08:45:02 PST
Created attachment 78534 [details] Patch.
Yury Semikhatsky
Comment 2 2011-01-14 02:22:56 PST
Comment on attachment 78534 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=78534&action=review > Source/WebCore/inspector/front-end/Breakpoint.js:90 > + function gotSourceLine(text) in WebKit didGet... naming style is used > Source/WebCore/inspector/front-end/Script.js:60 > +WebInspector.Script.findLineEndings = function(source) This should be declared in utilities.js, maybe on String.prototype > Source/WebCore/inspector/front-end/Script.js:82 > + findLineEndings: function(callback) this method should be private > Source/WebCore/inspector/front-end/Script.js:123 > + function gotScriptSource(source) in WebKit didGet... naming style is used > Source/WebCore/inspector/front-end/Script.js:127 > + for (var i = 0; i < this.startingLine - 1; ++i) why do you need this? > Source/WebCore/inspector/front-end/Script.js:131 looks like you need to add this message to localizedStrings.js
Pavel Podivilov
Comment 3 2011-01-14 05:00:16 PST
Created attachment 78925 [details] Comments addressed.
Pavel Podivilov
Comment 4 2011-01-14 07:58:53 PST
Committed r75795: <http://trac.webkit.org/changeset/75795>
Note You need to log in before you can comment on or make changes to this bug.