WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
52077
[Qt] QtWebKit always supports cookies
https://bugs.webkit.org/show_bug.cgi?id=52077
Summary
[Qt] QtWebKit always supports cookies
Benjamin Poulain
Reported
2011-01-07 13:17:49 PST
The function bool cookiesEnabled(const Document* document) does not actually need to check anything, it is not possible to disable cookies with Qt. Checking for the cookie jar was useless because one is created on the fly is none is set: QNetworkCookieJar *QNetworkAccessManager::cookieJar() const { Q_D(const QNetworkAccessManager); if (!d->cookieJar) d->createCookieJar(); return d->cookieJar; } Checking for the network access manager is not useful for the same reason.
Attachments
Add attachment
proposed patch, testcase, etc.
Benjamin Poulain
Comment 1
2011-01-07 13:26:46 PST
Invalid. I realised my mistake while doing the autotest. QNetworkAccessManagerPrivate::createCookieJar() creates the jar only once. You can set a null cookie jar and the current implementation of cookiesEnabled() is incorrect. Follow up bug report soon.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug