RESOLVED FIXED 50668
Bopomofo should be part of CJK Ideographs in WebCore/platform/graphics/Font.cpp 
https://bugs.webkit.org/show_bug.cgi?id=50668
Summary Bopomofo should be part of CJK Ideographs in WebCore/platform/graphics/Font.cpp
Koan-Sin Tan
Reported 2010-12-07 22:50:50 PST
Bopomofo, which mainly used in Taiwan for educational purposes, is used to note the pronunciation of Han glyphs. It should be considered part of CJK Ideographs
Attachments
let Bopomofo, Bopomofo Extended, and tone marks be part of CJK (1.76 KB, patch)
2010-12-07 23:04 PST, Koan-Sin Tan 		no flags
DetailsFormatted DiffDiff
a test page to show this bug (69 bytes, text/plain)
2010-12-08 17:36 PST, Koan-Sin Tan 		no flags
Details
a snapshot picture to show what's wrong (60 bytes, text/plain)
2010-12-08 17:44 PST, Koan-Sin Tan 		no flags
Details
Let Bopomofo, Bopomofo Extended, and tone marks be part of CJK (1.98 KB, patch)
2010-12-08 20:04 PST, Koan-Sin Tan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Koan-Sin Tan
Comment 1 2010-12-07 23:04:27 PST
Created attachment 75875 [details] let Bopomofo, Bopomofo Extended, and tone marks be part of CJK
Alexey Proskuryakov
Comment 2 2010-12-08 14:03:37 PST
Does this have any observable effect? If so, this needs a test case - and otherwise, this change may not need to be made.
Koan-Sin Tan
Comment 3 2010-12-08 17:18:41 PST
(In reply to comment #2) > Does this have any observable effect? If so, this needs a test case - and otherwise, this change may not need to be made. Yes, pretty observable when you got certain "broken" fonts. I have made a test case, but the problem is to show the test case you need Microsoft copyrighted fonts, such as DFKai-SB [1]. I cannot find redistributable fonts which have the same problem yet. [1] http://www.microsoft.com/typography/fonts/font.aspx?FMID=838
Koan-Sin Tan
Comment 4 2010-12-08 17:36:51 PST
Created attachment 75992 [details] a test page to show this bug To see this page properly, you need 'resources/kaiu.ttf', which is not redistributable. However, it came with every Windows system :-)
Koan-Sin Tan
Comment 5 2010-12-08 17:44:30 PST
Created attachment 75994 [details] a snapshot picture to show what's wrong those Bopomofo glyphs in red circles should be rotated 90 degrees counterclockwise.
Alexey Proskuryakov
Comment 6 2010-12-08 19:13:23 PST
> I have made a test case, but the problem is to show the test case you need Microsoft copyrighted fonts, such as DFKai-SB [1]. I cannot find redistributable fonts which have the same problem yet. That's a a good explanation - it should go into ChangeLog, as the patch won't successfully land with OOPS. + // 0x2C7 Caron, Mandrin Chinese 3rd Tone Typo: should be Mandarin. Note that I do not intend to do final review on this patch - perhaps Dan (already CC'ed) would like to take a look.
Koan-Sin Tan
Comment 7 2010-12-08 20:04:38 PST
Created attachment 76007 [details] Let Bopomofo, Bopomofo Extended, and tone marks be part of CJK fix typo and add description of test case as suggested by Alexey
Eric Seidel (no email)
Comment 8 2010-12-10 00:11:29 PST
Comment on attachment 76007 [details] Let Bopomofo, Bopomofo Extended, and tone marks be part of CJK OK.
WebKit Review Bot
Comment 9 2010-12-10 02:37:04 PST
Comment on attachment 76007 [details] Let Bopomofo, Bopomofo Extended, and tone marks be part of CJK Clearing flags on attachment: 76007 Committed r73706: <http://trac.webkit.org/changeset/73706>
WebKit Review Bot
Comment 10 2010-12-10 02:37:09 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 11 2010-12-10 11:45:54 PST
http://trac.webkit.org/changeset/73706 might have broken GTK Linux 32-bit Debug
Note You need to log in before you can comment on or make changes to this bug.