RESOLVED FIXED 50562
Enable client-based geolocation in Chromium 
https://bugs.webkit.org/show_bug.cgi?id=50562
Summary Enable client-based geolocation in Chromium
John Knottenbelt
Reported 2010-12-06 04:49:22 PST
Set the CLIENT_BASED_GEOLOCATION flag in Chromium. Enable test fast/dom/Geolocation/delayed-permission-timeout.html
Attachments
Patch (1.05 KB, patch)
2010-12-13 09:21 PST, John Knottenbelt 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
John Knottenbelt
Comment 1 2010-12-13 09:21:27 PST
Created attachment 76391 [details] Patch
John Knottenbelt
Comment 2 2010-12-13 09:40:45 PST
Enable CLIENT_BASED_GEOLOCATION in the WebKit Chromium smoke tests in preparation for enabling client-based geolocation support in Chromium itself.
Jeremy Orlow
Comment 3 2010-12-16 02:09:47 PST
Comment on attachment 76391 [details] Patch r=me
WebKit Commit Bot
Comment 4 2010-12-16 05:38:38 PST
Comment on attachment 76391 [details] Patch Rejecting attachment 76391 [details] from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-attachment', '--non-interactive', 76391]" exit_code: 2 Last 500 characters of output: ailed to merge in the changes. Patch failed at 0001 2010-12-16 Yury Semikhatsky <yurys@chromium.org> When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at WebKitTools/Scripts/update-webkit line 132. Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2 Full output: http://queues.webkit.org/results/7080055
Jeremy Orlow
Comment 5 2010-12-16 07:05:45 PST
Comment on attachment 76391 [details] Patch Clearing flags on attachment: 76391 Committed r74189: <http://trac.webkit.org/changeset/74189>
Jeremy Orlow
Comment 6 2010-12-16 07:05:54 PST
All reviewed patches have been landed. Closing bug.
Eric Seidel (no email)
Comment 7 2010-12-16 14:35:15 PST
Sorry. The git repo on one of the commit-bots got corrupted. I'm attempting to fix it now.
Eric Seidel (no email)
Comment 8 2010-12-16 14:35:51 PST
Sorry. The git repo on one of the commit-queue bots got corrupted. :(
WebKit Review Bot
Comment 9 2010-12-16 15:38:50 PST
http://trac.webkit.org/changeset/74189 might have broken Leopard Intel Debug (Tests)
Note You need to log in before you can comment on or make changes to this bug.