Created attachment 73474 [details] Patch

Let's get this resolved before we add the client mock in Bug 49258.

Comment on attachment 73474 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=73474&action=review Sounds good to me. InspectorController/InspectorClient also follows this pattern. The only other example I can see of the other style is BackForwardController/BackForwardControllerClient. This patch appears to be missing the change to GeolocationClient.h/cpp? Also, it looks like you might need to rebase for win before landing. > WebKit/mac/WebView/WebView.mm:710 > + pageClients.geolocationControllerClient = new WebGeolocationClient(self); Can you fix up PageClients to reflect the new name?

Created attachment 73609 [details] Rename GeolocationControllerClient -> GeolocationClient Rename page clients as well.

Comment on attachment 73609 [details] Rename GeolocationControllerClient -> GeolocationClient Looks good but git has lost the SVN renaming history. I'll take the patch and fix it up with my SVN checkout.

Created attachment 73616 [details] Patch

LGTM. Patch is the same as mine, but with proper svn rename tracking.

The commit-queue encountered the following flaky tests while processing attachment 73616 [details]: http/tests/appcache/top-frame-3.html Please file bugs against the tests. These tests were authored by ap@webkit.org and dimich@chromium.org. The commit-queue is continuing to process your patch.

Comment on attachment 73616 [details] Patch Rejecting patch 73616 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'land-attachment', '--force-clean', '--ignore-builders', '--non-interactive', '--parent-command=commit-queue', 73616]" exit_code: 2 Last 500 characters of output: Kit/mac/WebView/WebView.mm M WebKit/win/ChangeLog M WebKit/win/WebKit.vcproj/WebKit.vcproj M WebKit/win/WebView.cpp A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output: svnlook: Can't write to stream: Broken pipe The following ChangeLog files contain OOPS: trunk/WebCore/ChangeLog Please don't ever say "OOPS" in a ChangeLog file. at /usr/local/git/libexec/git-core/git-svn line 558 Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1 Full output: http://queues.webkit.org/results/5698002

Created attachment 73726 [details] Patch

Comment on attachment 73726 [details] Patch Fixed 'OOPS'

The commit-queue encountered the following flaky tests while processing attachment 73726 [details]: fast/workers/storage/use-same-database-in-page-and-workers.html Please file bugs against the tests. These tests were authored by dumi@chromium.org. The commit-queue is continuing to process your patch.

Comment on attachment 73726 [details] Patch Clearing flags on attachment: 73726 Committed r71903: <http://trac.webkit.org/changeset/71903>

All reviewed patches have been landed. Closing bug.

http://trac.webkit.org/changeset/71903 might have broken GTK Linux 32-bit Release The following tests are not passing: http/tests/xmlhttprequest/xmlhttprequest-sync-vs-async-assertion-failure.html