RESOLVED FIXED 48426
Add runtime flag check before enabling speech input in code. 
https://bugs.webkit.org/show_bug.cgi?id=48426
Summary Add runtime flag check before enabling speech input in code.
Satish Sampath
Reported 2010-10-27 06:43:03 PDT
In https://bugs.webkit.org/show_bug.cgi?id=43146 I added a runtime flag for speech input and used that in the IDL where speech input attributes were declared. At that time I believed that was sufficient and no additions were necessary in the code. However I now find that only covers the V8/JSC bindings and not the inline attribute declarations in HTML. Hence this patch to add the runtime flag check in code.
Attachments
Patch (1.45 KB, patch)
2010-10-27 06:48 PDT, Satish Sampath 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Satish Sampath
Comment 1 2010-10-27 06:48:02 PDT
Created attachment 72028 [details] Patch
Steve Block
Comment 2 2010-10-27 07:59:39 PDT
Comment on attachment 72028 [details] Patch r=me
Steve Block
Comment 3 2010-10-27 08:00:26 PDT
Comment on attachment 72028 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=72028&action=review > WebCore/ChangeLog:6 > + https://bugs.webkit.org/show_bug.cgi?id=48426 Should add a comment about how this is tested.
WebKit Commit Bot
Comment 4 2010-10-27 08:16:58 PDT
Comment on attachment 72028 [details] Patch Clearing flags on attachment: 72028 Committed r70644: <http://trac.webkit.org/changeset/70644>
WebKit Commit Bot
Comment 5 2010-10-27 08:17:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.