RESOLVED FIXED 48339
Add a 'grammar' attribute for speech input. 
https://bugs.webkit.org/show_bug.cgi?id=48339
Summary Add a 'grammar' attribute for speech input.
Satish Sampath
Reported 2010-10-26 09:59:41 PDT
To differentiate between various types of speech input, we add a 'x-webkit-grammar' attribute to a speech enabled input element. This is passed without validation to the speech recognizer. Typical values could be "builtin:search", "builtin:dictation" and even an externally hosted SRGS grammar XML file URI. It is up to the recognizer to interpret the value and use it as an aid in recognition.
Attachments
Patch (13.18 KB, patch)
2010-10-26 10:06 PDT, Satish Sampath 		jorlow: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Satish Sampath
Comment 1 2010-10-26 10:06:02 PDT
Created attachment 71904 [details] Patch
Jeremy Orlow
Comment 2 2010-10-26 12:08:24 PDT
Comment on attachment 71904 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=71904&action=review r=me > WebCore/page/SpeechInputClient.h:34 > +#include <wtf/Forward.h> Needed? > WebCore/platform/mock/SpeechInputClientMock.cpp:53 > +bool SpeechInputClientMock::startRecognition(int requestId, const IntRect&, const String&) include name > WebCore/platform/mock/SpeechInputClientMock.h:53 > + bool startRecognition(int, const IntRect&, const String&); include name > WebKit/chromium/src/SpeechInputClientImpl.h:57 > + bool startRecognition(int, const WebCore::IntRect&, const WTF::String&); you should include a name here
Satish Sampath
Comment 3 2010-10-26 13:29:24 PDT
Comment on attachment 71904 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=71904&action=review Thanks, addressed the comments. Will land. >> WebCore/page/SpeechInputClient.h:34 >> +#include <wtf/Forward.h> > > Needed? Yes since we are using WTF::String in the added code below. >> WebCore/platform/mock/SpeechInputClientMock.cpp:53 >> +bool SpeechInputClientMock::startRecognition(int requestId, const IntRect&, const String&) > > include name Done >> WebCore/platform/mock/SpeechInputClientMock.h:53 >> + bool startRecognition(int, const IntRect&, const String&); > > include name Done >> WebKit/chromium/src/SpeechInputClientImpl.h:57 >> + bool startRecognition(int, const WebCore::IntRect&, const WTF::String&); > > you should include a name here Done
Satish Sampath
Comment 4 2010-10-26 13:41:02 PDT
Committed r70567: <http://trac.webkit.org/changeset/70567>
Note You need to log in before you can comment on or make changes to this bug.