RESOLVED FIXED 47766
Enrich /fast/dom/nodesFromRect-basic.html test 
https://bugs.webkit.org/show_bug.cgi?id=47766
Summary Enrich /fast/dom/nodesFromRect-basic.html test
Antonio Gomes
Reported 2010-10-16 05:49:33 PDT
In the test we are doing stuff like: check(53, 71, 0, 0, 0, 0, [e.body]); check(53, 71, 0, 10, 0, 10, [e.p3, e.body]); check(53, 71, 10, 0, 10, 0, [e.d1, e.h1, e.body]); check(53, 71, 10, 10, 10, 10, [e.p3, e.d1, e.h1, e.body]); Now that we support specifying the four direction to expansion separately, we can enrich these tests. It would turn to: check(53, 71, 0, 0, 0, 0, [e.body]); check(53, 71, 10, 0, 0, 0, [result]); check(53, 71, 0, 10, 0, 0, [result]); check(53, 71, 0, 0, 10, 0, [result]); check(53, 71, 0, 0, 0, 10, [result]); check(53, 71, 10, 10, 0, 0, [result]); check(53, 71, 10, 10, 0, 10, [result]); etc... Combinations are up to us.
Attachments
(committed r69939, r=smfr) patch v1. (7.99 KB, patch)
2010-10-17 20:46 PDT, Antonio Gomes 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antonio Gomes
Comment 1 2010-10-17 20:46:01 PDT
Created attachment 70991 [details] (committed r69939, r=smfr) patch v1. Patch makes fast/dom/nodesFromRect-basic.html test more precise: instead of calling nodesFromRect always with equal vertical (up and down) and horizontal (right and left) padding values, it are now tests it by passing different padding values on the various directions.
Antonio Gomes
Comment 2 2010-10-17 21:32:08 PDT
Comment on attachment 70991 [details] (committed r69939, r=smfr) patch v1. Clearing flags on attachment: 70991 Committed r69939: <http://trac.webkit.org/changeset/69939>
Note You need to log in before you can comment on or make changes to this bug.