WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
47528
new-run-webkit-tests: 'webkit-patch skipped-ports' introduced bad layering
https://bugs.webkit.org/show_bug.cgi?id=47528
Summary
new-run-webkit-tests: 'webkit-patch skipped-ports' introduced bad layering
Dirk Pranke
Reported
2010-10-11 18:12:29 PDT
bug 42832
/
r66872
introduced some unfortunate layering/dependency violations, by making the Port classes depend on the test_expectations library. This should be cleaned up by adding a generic routine that depends on both modules.
Attachments
Patch
(11.62 KB, patch)
2012-04-11 16:56 PDT
,
Dirk Pranke
abarth
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dirk Pranke
Comment 1
2012-04-11 16:56:04 PDT
Created
attachment 136789
[details]
Patch
Dirk Pranke
Comment 2
2012-04-11 17:13:52 PDT
Committed
r113927
: <
http://trac.webkit.org/changeset/113927
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug