WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
45553
Make FileEntry and DirectoryEntry methods accessible via Entry instance
https://bugs.webkit.org/show_bug.cgi?id=45553
Summary
Make FileEntry and DirectoryEntry methods accessible via Entry instance
Kinuko Yasuda
Reported
2010-09-10 11:30:45 PDT
Make FileEntry and DirectoryEntry methods accessible via Entry instance. Usually user script obtains an Entry (either file or directory) via callbacks as an 'Entry' instance, but since there's no concept of 'cast' in Javascript the script cannot call FileEntry- or DirectoryEntry-specific methods on the returned 'Entry' instance. Probably we could add some tricks in the binding code, or the quickest short-term solution would be: 1. (in idl) adding FileEntry- and DirectoryEntry-specific methods to Entry 2. (in c++ impl) making the methods virtual 3. throws an exception if Entry's base implementation is called.
Attachments
Patch
(11.57 KB, patch)
2010-09-10 12:02 PDT
,
Kinuko Yasuda
no flags
Details
Formatted Diff
Diff
Patch
(20.18 KB, patch)
2010-09-13 17:57 PDT
,
Kinuko Yasuda
no flags
Details
Formatted Diff
Diff
Patch
(19.10 KB, patch)
2010-09-13 18:07 PDT
,
Kinuko Yasuda
abarth
: review+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Kinuko Yasuda
Comment 1
2010-09-10 12:02:59 PDT
Created
attachment 67219
[details]
Patch Work-around patch
Kinuko Yasuda
Comment 2
2010-09-13 17:57:42 PDT
Created
attachment 67495
[details]
Patch
Adam Barth
Comment 3
2010-09-13 18:05:33 PDT
Comment on
attachment 67495
[details]
Patch great!
Kinuko Yasuda
Comment 4
2010-09-13 18:07:25 PDT
Created
attachment 67497
[details]
Patch Removed unnecessary changes.
Kinuko Yasuda
Comment 5
2010-09-13 18:14:09 PDT
(In reply to
comment #3
)
> (From update of
attachment 67495
[details]
) > great!
Oops... mid-air collision :( Could you r+ one more time on the new one? Thanks so much.
https://bugs.webkit.org/attachment.cgi?id=67497&action=edit
Kinuko Yasuda
Comment 6
2010-09-13 21:59:43 PDT
Committed
r67443
: <
http://trac.webkit.org/changeset/67443
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug