RESOLVED INVALID 44322
Client-based geolocation missing error handling 
https://bugs.webkit.org/show_bug.cgi?id=44322
Summary Client-based geolocation missing error handling
Mahesh Kulkarni
Reported 2010-08-19 22:19:42 PDT
GeolocationControllerClient interface missing error handling incase of unavailability of user location. if startUpdating() returns error from platform client listeners should be notified of POSITION_UNAVAILABLE error
Attachments
Add attachment proposed patch, testcase, etc.
Steve Block
Comment 1 2010-08-20 01:08:01 PDT
Can you explain exactly what error handling is missing? I don't think there's any need for GeolocationControllerClient::startUpdating() to return a boolean indicating success. If the client fails to start the location acquisition process, it should asynchronously call GeolocationController::errorOccurred(). The fact that GeolocationService::startUpdating() returns a boolean is awkward, as in the case of an error, it requires the Geolocation object to manage making the error callback asynchronous.
Jarred Nicholls
Comment 2 2010-12-14 08:50:19 PST
I agree with Steve. The fact that it's client-based alone should imply that the client asynchronously informs Geolocation by calling errorOccurred(), IMHO.
Mahesh Kulkarni
Comment 3 2011-02-07 20:38:51 PST
(In reply to comment #1) > Can you explain exactly what error handling is missing? > > I don't think there's any need for GeolocationControllerClient::startUpdating() to return a boolean indicating success. If the client fails to start the location acquisition process, it should asynchronously call GeolocationController::errorOccurred(). > > The fact that GeolocationService::startUpdating() returns a boolean is awkward, as in the case of an error, it requires the Geolocation object to manage making the error callback asynchronous. Makes sense. Closing the bug. Thanks Steve and Jarred.
Note You need to log in before you can comment on or make changes to this bug.