RESOLVED WONTFIX 43115
[Qt] QScriptValue should hhave API for accessing a private data. 
https://bugs.webkit.org/show_bug.cgi?id=43115
Summary [Qt] QScriptValue should hhave API for accessing a private data.
Attachments
Fix v1 (6.32 KB, patch)
2010-07-28 05:16 PDT, Jędrzej Nowacki 		ariya.hidayat: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jędrzej Nowacki
Comment 1 2010-07-28 05:16:15 PDT
Created attachment 62814 [details] Fix v1
Ariya Hidayat
Comment 2 2010-08-08 12:51:07 PDT
Comment on attachment 62814 [details] Fix v1 > + [Qt] QScriptValue should hhave API for accessing a private data. Typo at "hhave". > + QExplicitlySharedDataPointer<QScriptValuePrivate> m_objectData; Can't you use the new QSharedPointer instead? > +QScriptValuePrivate* QScriptValuePrivate::data() const > +{ > + if (m_objectData) > + return m_objectData.data(); > + return new QScriptValuePrivate(); > +} Is this asking for a leak? If there is a way to use QSharedPointer, we can even pass QSharedPointer back instead of raw pointer? r- for these minor issues. Otherwise LGTM.
Jędrzej Nowacki
Comment 3 2011-07-07 07:52:58 PDT
Porting QtScript API over JSC C API will not be continued.
Note You need to log in before you can comment on or make changes to this bug.